fix(mcp): use is not None to cache empty tools list correctly#3496
Closed
rmotgi1227 wants to merge 1 commit into
Closed
fix(mcp): use is not None to cache empty tools list correctly#3496rmotgi1227 wants to merge 1 commit into
rmotgi1227 wants to merge 1 commit into
Conversation
Member
|
An empty list here is not expected plus if that happens, skipping the saved empty data should be fine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an MCP server returns an empty tools list,
self._tools_listis[]which is falsy. The cache checktreats an empty cached list the same as an uncached one, causing a redundant re-fetch on every subsequent
list_tools()call even whencache_tools_list=Trueand the cache is clean.The field is initialized to
None(line 600) to mean "not yet fetched," so the correct guard isis not None.