Skip to content

chore(ci): pin setup-uv v5 to its underlying commit - #3560

Merged
jbeckwith-oai merged 1 commit into
openai:mainfrom
MGPOCKY:fix/ci-invalid-action-ref
Jul 31, 2026
Merged

chore(ci): pin setup-uv v5 to its underlying commit#3560
jbeckwith-oai merged 1 commit into
openai:mainfrom
MGPOCKY:fix/ci-invalid-action-ref

Conversation

@MGPOCKY

@MGPOCKY MGPOCKY commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Problem

These workflow uses: pins are invalid as written. Each item below shows the current value, why it is wrong, and the correct ref that must be used instead.

1. .github/workflows/detect-breaking-changes.yml

Current (invalid):

uses: astral-sh/setup-uv@e58605a9b6da7c637471fab8847a5e5a6b8df081 # v5

Why this is wrong:

  • e58605a9b6da7c637471fab8847a5e5a6b8df081 is not a commit SHA. It is the Git object SHA of an annotated tag (v5).
  • GitHub Actions does not accept annotated tag object SHAs in uses: pins (Commits API returns No commit found for SHA).
  • The correct pin is the commit SHA that tag v5 points to: d4b2f3b6ecc6e67c4457f6d3e41ec42d3d0fcb86.

Correct pin:

uses: astral-sh/setup-uv@d4b2f3b6ecc6e67c4457f6d3e41ec42d3d0fcb86 # v5

Test plan

  • Each updated uses: ref resolves as a commit via the GitHub Commits API
  • Relevant CI jobs on this branch look healthy

@MGPOCKY
MGPOCKY marked this pull request as ready for review July 31, 2026 13:03
@MGPOCKY
MGPOCKY requested a review from a team as a code owner July 31, 2026 13:03
@jbeckwith-oai jbeckwith-oai changed the title fix(ci): replace invalid Actions pin with the commit SHA it resolves to chore(ci): pin setup-uv v5 to its underlying commit Jul 31, 2026

@jbeckwith-oai jbeckwith-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MGPOCKY for catching this and for the focused change. I verified that e58605a9b6da7c637471fab8847a5e5a6b8df081 is the annotated v5 tag object and that d4b2f3b6ecc6e67c4457f6d3e41ec42d3d0fcb86 is the commit it points to. Pinning the underlying full commit SHA is the conventional form recommended by GitHub, so the code change itself looks correct.

One factual correction for the PR description: GitHub Actions does accept and currently execute the annotated-tag object SHA—the latest main workflow runs successfully download and run that exact ref. The Commits API returning 422 does not imply that the Actions resolver rejects it. Please reframe the description as normalizing the pin to the underlying commit SHA, rather than fixing an unusable workflow reference.

The PR's workflow is also currently action_required and spawned no jobs, so CI should be allowed to run before merge. I found no code-level issues with the one-line change.

@jbeckwith-oai
jbeckwith-oai merged commit cbdc98b into openai:main Jul 31, 2026
11 of 12 checks passed
@stainless-app stainless-app Bot mentioned this pull request Jul 31, 2026
jbeckwith-oai pushed a commit that referenced this pull request Aug 3, 2026
Automated Release PR
---


## 2.52.1 (2026-07-31)

Full Changelog:
[v2.52.0...v2.52.1](v2.52.0...v2.52.1)

### Chores

* **ci:** pin setup-uv v5 to its underlying commit
([#3560](#3560))
([cbdc98b](cbdc98b))

---
This pull request is managed by Stainless's [GitHub
App](https://github.com/apps/stainless-app).

The [semver version
number](https://semver.org/#semantic-versioning-specification-semver) is
based on included [commit
messages](https://www.conventionalcommits.org/en/v1.0.0/).
Alternatively, you can manually set the version number in the title of
this pull request.

For a better experience, it is recommended to use either rebase-merge or
squash-merge when merging this pull request.

🔗 Stainless [website](https://www.stainlessapi.com)
📚 Read the [docs](https://app.stainlessapi.com/docs)
🙋 [Reach out](mailto:support@stainlessapi.com) for help or questions

Co-authored-by: stainless-app[bot] <142633134+stainless-app[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants