chore(skills): prioritize customer-impacting Ruby SDK defects - #519
Conversation
jbeckwith-oai
added
the
codex-maintenance
Castiron custom code✅ No new custom-code files detected. 47 mixed files remain; 0 existing customizations changed. Compared 47 existing customizations unchanged
7 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 32877898575 --repo openai/openai-ruby \
--name castiron-custom-code-32877898575-1 --dir /tmp/castiron-custom-code-32877898575-1
git apply --stat /tmp/castiron-custom-code-32877898575-1/custom-code.patch
cat /tmp/castiron-custom-code-32877898575-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin dd0a37cb1783adc7282603d8d2c9a8f11319b205 5780d9423caed284961d5f3b72875769290be0c2
python3 scripts/castiron/custom_code_report.py report \
--base dd0a37cb1783adc7282603d8d2c9a8f11319b205 \
--head 5780d9423caed284961d5f3b72875769290be0c2 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-5780d9423cae
cat /tmp/castiron-custom-code-5780d9423cae/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5b5c8dd7ff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4d92806caf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 556d95be86
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jbeckwith-oai
changed the title
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 35d2d4bd28
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 71ccf5fec8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
apcha-oai
left a comment
apcha-oai
left a comment
There was a problem hiding this comment.
[sdk codex review] Requesting changes at 71ccf5fec8e98f74814b7a2c3fffd71f4eb9ef65 after two independent full reviews of the sole Markdown change and all existing feedback. The following existing policy-correctness issues remain; I am referencing their threads instead of adding duplicate inline comments:
- Terminal failure/cancellation reconciliation: a task that must stop without proof or a PR cannot reach the successful handoff required to release its finding, paths and capacity. Allow release for independently confirmed terminal failures/cancellations without an open PR, while retaining active or ambiguous reservations.
- In-scope review handling: retain the Markdown-only boundary, but narrow the blanket instruction to ignore PR #519 feedback so legitimate corrections within this file can still be assessed.
- Owned-draft label failure: restore cleanup/reconciliation for a definitely identified draft created by this task when mandatory labeling fails. I am not asserting automatic cap overflow: the retained task reservation may still prevent a replacement, but the unlabeled draft is left stranded.
The obsolete coordinator-script findings are not current defects in this one-file diff. Existing hosted Ruby 3.3.12/3.4.10/4.0.6 jobs verified this head merged with current base c3fe427c6e9d9fad78acd23118b897ab0d6c5611; each passed 1,209 tests and 10,715 assertions. Current CI/budget statuses are green apart from expected skips, but runtime suites do not validate these policy transitions. No skill, code, tests or scans were executed locally. Final head/base/merge-base, author, open/non-draft status and mergeability were verified.
2 participants
Summary
Scope and compatibility
.agents/skills/improve-openai-ruby/SKILL.md; no runtime, generated SDK code, API, dependency, CI workflow, orAGENTS.mdchanges.Verification
quick_validate.pyagainst.agents/skills/improve-openai-ruby.RDoc::Markdownparsing checks.TMPDIR=/private/tmp bundle exec rake testunder Ruby 4.0.6 — 1,191 tests, 10,593 assertions, 0 failures, 0 errors, 1 existing skip.bundle exec rake lintunder Ruby 4.0.6 — 2,746 Ruby files inspected; 1,239 RBS files validated; Sorbet and formatting checks pass.python3 -m unittest discover -s scripts/castiron -p 'test_custom_code*.py'— 51 tests pass, 1 existing skip.git diff --checkandgit diff --stat edfb30b2973d68b4a19ce3f86f1de7313f730702.