feat(realtime): add sideband WebSocket call control - #530
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Castiron custom code✅ No new custom-code files detected. 47 mixed files remain; 0 existing customizations changed. Compared 47 existing customizations unchanged
7 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 32888347653 --repo openai/openai-ruby \
--name castiron-custom-code-32888347653-1 --dir /tmp/castiron-custom-code-32888347653-1
git apply --stat /tmp/castiron-custom-code-32888347653-1/custom-code.patch
cat /tmp/castiron-custom-code-32888347653-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin d638c57853bcd2d1afb44fdf5fc1f79e891c138e 561d72481192518108a4f96b6a00f4c8b7aa106a
python3 scripts/castiron/custom_code_report.py report \
--base d638c57853bcd2d1afb44fdf5fc1f79e891c138e \
--head 561d72481192518108a4f96b6a00f4c8b7aa106a --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-561d72481192
cat /tmp/castiron-custom-code-561d72481192/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fa98d11024
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 828b0a7e79
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
HAYDEN-OAI
left a comment
HAYDEN-OAI
left a comment
There was a problem hiding this comment.
Reviewed sideband authorization and call-ID isolation, WebSocket URL and credential handling, HTTP trace/error redaction, proxy/TLS protections, retry/lifecycle cleanup, and typed audio controls; no substantive issues found.
2 participants
Summary
client.realtime.connect_to_call(call_id:)and a typedOpenAI::Realtime::SidebandConnectionfor server-side control of existing, application-authorized WebRTC or SIP calls.output_audio_buffer.clearand genericconversation.items.truncate, with documented cancel → truncate → clear interruption ordering and no implicit call ownership or hangup.Verification
bundle exec rake test— 1,404 tests, 12,703 assertions, zero failures.bundle exec rake test— 1,404 tests, 12,703 assertions, zero failures.bundle exec rake test— 1,404 tests, 12,702 assertions, zero failures.bundle exec rake lint— RuboCop, rubyfmt, Sorbet, and 1,245 RBS files pass.