Skip to content

docs(spindle-ui): ButtonのDesign DocにContained/Outlined並び順ガイドラインを追加#2156

Open
MasatoHonda wants to merge 5 commits into
mainfrom
docs/button-design-doc-layout-guidelines
Open

docs(spindle-ui): ButtonのDesign DocにContained/Outlined並び順ガイドラインを追加#2156
MasatoHonda wants to merge 5 commits into
mainfrom
docs/button-design-doc-layout-guidelines

Conversation

@MasatoHonda

Copy link
Copy Markdown
Contributor

縦並び・横並び時のContainedボタンとOutlinedボタンの配置ルールを
スクリーンショットとDO/DO NOTに追記した。

縦並び・横並び時のContainedボタンとOutlinedボタンの配置ルールを
スクリーンショットとDO/DO NOTに追記した。
@changeset-bot

changeset-bot Bot commented Jun 4, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: c180380

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Visit the preview URL for this PR (updated for commit c180380):

https://ameba-spindle--pr2156-docs-button-design-d-l32wnwm7.web.app

(expires Sat, 11 Jul 2026 06:39:59 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e7521619a2dd5c653490c8246e81ec2a5c8f1435

@reg-suit

reg-suit Bot commented Jun 4, 2026

Copy link
Copy Markdown

reg-suit detected visual differences.

Check this report, and review them.

🔴 Changed ⚪ New 🔵 Passing
2 1 256
How can I change the check status? If reviewers approve this PR, the reg context status will be green automatically.

Contained/Outlined並び順ガイドラインをButtonからButtonGroupに移動。
スクリーンショット・DO/DO NOT・Storybookガイドラインセクションを追加した。
@herablog

herablog commented Jun 8, 2026

Copy link
Copy Markdown
Member

@MasatoHonda lint commit message(s) / lint commit message(s) (pull_request)だけ修正お願いします!

@MasatoHonda MasatoHonda force-pushed the docs/button-design-doc-layout-guidelines branch from 5c22469 to 5e5fd60 Compare June 10, 2026 00:48
@MasatoHonda

Copy link
Copy Markdown
Contributor Author

@herablog 修正しましたー
regで差分が出てるんですが、今回の変更箇所と関係ないところっぽいんですが、これはどうしましょう

@herablog herablog left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VRTは確認して許容できるものなのでこのままで大丈夫です!残り以下対応お願いします。

Comment thread packages/spindle-ui/src/ButtonGroup/ButtonGroup.mdx Outdated
Comment thread packages/spindle-ui/src/ButtonGroup/design-doc.md Outdated

### 横に並べる場合

Outlinedボタンを**左**に配置します。

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

記述と描画が違いそうっす
Image

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あ、これはStorybook側から考え直さないといけなかった可能性がありますね…?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Storybookの例が違ってたら直しちゃいたいっすね!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants