test(spindle-ui): check aria attributes in Breadcrumb#771
Open
herablog wants to merge 2 commits into
Open
Conversation
|
✨✨ That's perfect, there is no visual difference! ✨✨ Check out the report here. |
Contributor
|
Visit the preview URL for this PR (updated for commit dfc2d90): https://ameba-spindle--pr771-test-breadcrumb-82ienvbh.web.app (expires Fri, 08 Sep 2023 09:33:08 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e7521619a2dd5c653490c8246e81ec2a5c8f1435 |
tokimari
reviewed
Aug 10, 2023
| expect(screen.getByRole('navigation').getAttribute('aria-label')).toEqual( | ||
| 'パンくずリスト', | ||
| ); | ||
| expect(screen.getByText('Amebaとは').getAttribute('aria-current')).toEqual( |
Contributor
There was a problem hiding this comment.
nits. Top, Teamのリンクには aria-current が無いこともテストしておきますか？？
| @@ -0,0 +1,25 @@ | |||
| import React from 'react'; | |||
Contributor
There was a problem hiding this comment.
q.
spindle/packages/spindle-ui/tsconfig.json
Line 17 in dfc2d90
（Button.test.tsxも同様でした）
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BreadcrumbのDesign Docを見ていく中で、
aria-*の確認できていないなあだったのでテストを追加しました。