OBPIH-7532: Add test to change locations on putaway pages #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alannadolny
reviewed
Dec 18, 2025
|
|
||
| get emptyPutawayList() { | ||
| return this.page | ||
| .locator('.empty fade center') |
Collaborator
There was a problem hiding this comment.
Isn't there a better selector than those coming from Bootstrap?
| } | ||
|
|
||
| get orderNumber() { | ||
| return this.row.getByTestId('order-number-0'); |
Collaborator
There was a problem hiding this comment.
Is the -0 working? The idea of that was that the number at the end is the row number
| } | ||
|
|
||
| get receivingBin() { | ||
| return this.row.getByTestId('cell-undefined-undefined'); |
Collaborator
There was a problem hiding this comment.
this -undefined-undefined data-testid should be fixed 😢
| await test.step('Change location to another depot', async () => { | ||
| await navbar.locationChooserButton.click(); | ||
| await locationChooser | ||
| .getOrganization(depotLocation.organization?.name as string) |
Collaborator
There was a problem hiding this comment.
Why is it cast to a string? I think here we should be sure that the name is not null, so the type casting shouldn't be required
Comment on lines
+187
to
+189
| await test.step('Return to main location', async () => { | ||
| await authService.changeLocation(AppConfig.instance.locations.main.id); | ||
| }); |
Collaborator
There was a problem hiding this comment.
Shouldn't you somehow check if that redirect works?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test for changing location on create putaway page and assert its content and change location on list putaway page