Conversation
Triage result
Quick readThis PR targets the right symptom from #165, but the current solution is not safe enough to continue. The new "pristine session" heuristic relies only on locally persisted state, so it can misclassify a legitimately resumed ACP session as disposable and replace it with a fresh one. IntentThe intent here is to avoid an unnecessary WhyThe problem is that the heuristic is too local.
Codex reviewNot run in this step. This was a read-only triage judgment. CI/CDNot run in this step. Validation and CI are intentionally deferred by the flow. RecommendationClose this PR. A follow-up should distinguish "fresh local wrapper around a brand-new ACP session" from "empty local record that points at a resumed remote ACP session", and it should add a regression test covering prompt/reconnect behavior for sessions created via |
|
Closed by automated triage. |
Summary
session/loadfor pristine saved sessions that have no turns yet and only need a fresh ACP sessionWhy
Issue #165 reports a large delay before the first streamed text event on
codex prompt --sessioncompared withcodex exec.For freshly ensured sessions with no prior turns,
acpxwas still attemptingsession/loadbefore the first prompt. On Codex, that extra resume path appears to be the wrong fit for a pristine session and can delay the first streamed output. This change sends those pristine sessions straight tosession/newinstead.Fixes #165.
Validation
pnpm run buildpnpm run build:testnode --test dist-test/test/connect-load.test.jsnode --test dist-test/test/prompt-runner.test.js