feat: handle UI_PickLink postMessage from Collabora Online#2435
Open
pedropintosilva wants to merge 1 commit intoopencloud-eu:mainfrom
Open
feat: handle UI_PickLink postMessage from Collabora Online#2435pedropintosilva wants to merge 1 commit intoopencloud-eu:mainfrom
pedropintosilva wants to merge 1 commit intoopencloud-eu:mainfrom
Conversation
Open the existing FilePickerModal and reply with Action_InsertLink
carrying {url: resource.privateLink, text: resource.name} so Collabora
Online inserts a hyperlink to the picked file (label =
filename). Requires EnableRemoteLinkPicker=true in CheckFileInfo,
added in the companion opencloud-eu/opencloud PR.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UI_PickLinkpostMessage by opening the existingFilePickerModaland replying withAction_InsertLinkcarrying{url: resource.privateLink, text: resource.name}.EnableRemoteLinkPicker: trueto CheckFileInfo.Details
Reuses the same file-picker infrastructure as the existing
UI_InsertFile/UI_InsertGraphichandlers. Thetextfield is an optional argument honoured by coolwsd since CollaboraOnline/online#15561 (MERGED) — older coolwsd ignores it and falls back to the URL, so this change is backward-compatible with any coolwsd release.SDK reference: https://sdk.collaboraonline.com/docs/postmessage_api.html#ui-picklink-ui-editor-host