Skip to content

feat(schema): add omitHeaders to http request settings #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pooja-bruno wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −2
Open

feat(schema): add omitHeaders to http request settings #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/oc-schema/src/opencollection.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1756,6 +1756,13 @@
}
],
"description": "Maximum number of redirects to follow"
},
"omitHeaders": {
"type": "array",
"description": "Names of default headers to omit from the request",
"items": {
"type": "string"
}
}
},
"additionalProperties": false
Expand Down
5 changes: 3 additions & 2 deletions packages/oc-spec-site/src/components/sections/HttpRequest.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,8 @@ settings:
timeout: 30000
followRedirects: true
forwardAuthorizationHeader: true
maxRedirects: 5`;
maxRedirects: 5
omitHeaders: []`;

return (
<section>
Expand Down Expand Up @@ -161,7 +162,7 @@ settings:
<h3 className={typography.heading.h3}>Properties</h3>
<PropertyTable
properties={httpRequestSettings.properties}
order={['encodeUrl', 'timeout', 'followRedirects', 'forwardAuthorizationHeader', 'maxRedirects']}
order={['encodeUrl', 'timeout', 'followRedirects', 'forwardAuthorizationHeader', 'maxRedirects', 'omitHeaders']}
required={httpRequestSettings.required}
/>

Expand Down
7 changes: 7 additions & 0 deletions packages/oc-spec-site/src/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1598,6 +1598,13 @@
}
],
"description": "Maximum number of redirects to follow"
},
"omitHeaders": {
"type": "array",
"description": "Names of default headers to omit from the request",
"items": {
"type": "string"
}
}
},
"additionalProperties": false
Expand Down
1 change: 1 addition & 0 deletions packages/oc-types/src/requests/http.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ export interface HttpRequestSettings {
followRedirects?: boolean | 'inherit';
forwardAuthorizationHeader?: boolean | 'inherit';
maxRedirects?: number | 'inherit';
omitHeaders?: string[];
}

export interface HttpRequestExampleRequest {
Expand Down