Allow creation of virtual environment during the CMake configuration step#150
Open
Allow creation of virtual environment during the CMake configuration step#150
Conversation
Collaborator
|
@compor I checked out this branch on my desktop machine (fedora) and after running I get the following error: The output of my @superlopuh are you able to reproduce this error on your machine? |
Contributor
|
What happens if you activate the venv before running the command? |
Collaborator
|
The same thing. I did and I get the same output: |
Contributor
|
sorry, did you do |
Contributor
|
what happens if you do |
Collaborator
|
Sorry, I made a typo. I ran |
Contributor
|
Yay! |
Collaborator
Author
|
@EmilySillars thank you for checking, this is the expected behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is working towards #149 (a few PRs on the way) by:
venvdir) from within the top-level CMake file.It eliminates the need to create a virtual environment (venv) before issuing the CMake configuration, but it does not prevent the user from creating one manually if desired.
Update: Forgot to mention that this maintains the current functionality, and it is orthogonal with the current open PRs wrt CMake changes.
CC: @EmilySillars