feat: Added tests for verifying course visibility options and schedule and details settings by irin2811 · Pull Request #162 · openedx/cypress-e2e-tests

irin2811 · 2026-01-26T13:33:15Z

Smoke tests:

Test course visibility in catalog: none, about and both behavior (case: not enroled student on a course)
Regression tests:
Set pacing to instructor paced
Set pacing to self paced
Set start date and end date
Set start time and end time

Added based Schedule and Details Tests: - [TC_AUTHOR_106] Set pacing to instructor paced [TC_AUTHOR_107] Set pacing to self paced [TC_AUTHOR_108] Set start date and end date

move general api methods to separate file, fixing lint issues

Added tests for [TC_AUTHOR_109] Set start time and end time

Added tests - [TC_AUTHOR_133] Check course visibility "both" - add methods for advanced settings tests - fix lint issues

openedx-webhooks · 2026-01-26T13:33:20Z

Thanks for the pull request, @irin2811!

This repository is currently maintained by @openedx/committers-cypress-e2e-tests.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

cmltaWt0

Beautiful work! 💟

I like API-driven test setup - using direct API calls to configure course dates/pacing/visibility instead of clicking through UI is fast and reliable, searchReindex integration correctly triggers search reindex after visibility changes so the course catalog reflects updates, pages structure, test coverage, preserved skipped tests etc.
It's really solid PR.

Let's just consider my suggestions to make it even better.

cmltaWt0 · 2026-02-08T10:20:40Z

cypress/support/apiHelpers.js

+export const getCsrfToken = () => cy.getAllCookies() // gets all cookies from browser
+  .then((allCookiesArray) => {
+    const csrfCookie = allCookiesArray.find( // filter by domain and cookie name
+      (cookieObj) => cookieObj.domain === getDomain()


You can get a cookie by name and specified domain.
https://docs.cypress.io/api/commands/getcookie

cmltaWt0 · 2026-02-08T10:22:58Z

cypress/support/apiHelpers.js

+}
+
+// Get CSRF token from cookies
+export const getCsrfToken = () => cy.getAllCookies() // gets all cookies from browser


Should we refactor cy.getCookie('csrftoken') in commands.js to have a single way of doing thing?

cmltaWt0 · 2026-02-08T10:24:48Z

cypress/e2e/studio/settings/testAdvancedSettings.cy.js

+    advancedSettings.courseVisibility(courseId, 'none')
+      .then(() => scheduleAndDetails.searchReindex(courseId))
+      // eslint-disable-next-line cypress/no-unnecessary-waiting
+      .then(() => cy.wait(2000)) // reduce flakiness


Either poll the search endpoint until the updated visibility takes effect, or at minimum make the wait duration configurable via an env var or constant so it can be tuned per environment (for really slow ones).

cmltaWt0 · 2026-02-08T10:29:42Z

cypress/pages/studio/settings/scheduleAndDetails.js

+      }))
+  }
+
+  searchReindex(courseId) {


This is a general helper that should not be coupled to scheduleAndDetails page.
Please move to to utility/helper.

cmltaWt0 · 2026-02-08T10:30:14Z

cypress/pages/studio/settings/scheduleAndDetails.js

+  }
+
+  // Helper: Get an offset date from today
+  getDateWithOffset(daysAhead = 10) {


The same as above. Please decouple from the current page and move to a shared helpers.

cmltaWt0 · 2026-02-08T10:43:40Z

cypress/e2e/studio/settings/testScheduleAndDetailsSettings.cy.js

+      cy.visit(`${baseMFEURL}/learning/course/${courseId}/home`)
+
+      // Verify that the course content is accessible
+      cy.contains('Begin your course today').should('be.visible')


Just a note for a future ourselves - do thing about localization.

cmltaWt0 · 2026-02-08T10:44:35Z

cypress/e2e/studio/settings/testAdvancedSettings.cy.js

+  let endDateTime
+  let startEnrollDateTime
+
+  before(function () {


Could we use arrow function consistently across the whole codebase?

I'd prefer to keep existing style for consistency with the current file, and suggest doing it in a separate refactor/formatting PR for making it consistently across the codebase

cmltaWt0 · 2026-02-08T10:44:42Z

cypress/e2e/studio/settings/testAdvancedSettings.cy.js

+    cy.clearCookies()
+  })
+
+  beforeEach(function () {


The same as above.

cmltaWt0 · 2026-02-08T10:47:14Z

cypress/e2e/studio/settings/testScheduleAndDetailsSettings.cy.js

-  it.skip('Set pacing to instructor paced', () => {
+import ScheduleAndDetails from '../../../pages/studio/settings/scheduleAndDetails'
+import AboutCoursePage from '../../../pages/lms/courseAboutPage'
+import { getCsrfToken } from '../../../support/apiHelpers'


Unused import.

cmltaWt0 · 2026-02-08T10:50:02Z

cypress/e2e/studio/settings/testScheduleAndDetailsSettings.cy.js

+      scheduleAndDetails.setInstructorPaced(courseId)
+
+      // Verify the pacing is set to instructor paced
+      getCsrfToken().then((token) => {


The test is importing the test helpers/infrastructure (getCsrfToken) directly rather than using it through the page objects.
Consider whether the pacing verification could be a method on the ScheduleAndDetails page object (e.g., verifyPacing(courseId, expectedSelfPaced)).

irin2811 and others added 6 commits December 30, 2025 11:25

feat: [CC-167] Schedule and Details settings

5f5468d

Added based Schedule and Details Tests: - [TC_AUTHOR_106] Set pacing to instructor paced [TC_AUTHOR_107] Set pacing to self paced [TC_AUTHOR_108] Set start date and end date

feat: [CC-167] code optimisation, fixing errors

384b88e

move general api methods to separate file, fixing lint issues

feat: [CC-167] Schedule and Details settings tests

3c7797f

Added tests for [TC_AUTHOR_109] Set start time and end time

feat: [CC-148] add test for advanced settings

1b7809d

Added tests - [TC_AUTHOR_133] Check course visibility "both" - add methods for advanced settings tests - fix lint issues

feat: [CC-148] fixing advanced settings logic +fix lint issues

7b02f18

Merge branch 'openedx:master' into advanced-settings-tests

d845650

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 26, 2026

openedx-webhooks added this to Contributions Jan 26, 2026

github-project-automation bot moved this to Needs Triage in Contributions Jan 26, 2026

mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Jan 27, 2026

mphilbrick211 requested a review from a team January 27, 2026 21:24

cmltaWt0 reviewed Feb 8, 2026

View reviewed changes

cmltaWt0 assigned irin2811 Feb 8, 2026

Comments

Conversation

irin2811 commented Jan 26, 2026

Uh oh!

openedx-webhooks commented Jan 26, 2026

Uh oh!

cmltaWt0 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants