refactor: standardized button styling system in the app#410
Open
farhan-arshad-dev wants to merge 4 commits intoopenedx:developfrom
Open
refactor: standardized button styling system in the app#410farhan-arshad-dev wants to merge 4 commits intoopenedx:developfrom
farhan-arshad-dev wants to merge 4 commits intoopenedx:developfrom
Conversation
- Define styling for buttons types (primary, secondary, tertiary, error, etc.) to make button styles configurable. fixes: LEARNER-10140
farhan-arshad-dev
requested review from
HamzaIsrar12 and
omerhabib26
and removed request for
HamzaIsrar12
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
added 3 commits
November 22, 2024 11:00
- Minor UI improvements. fixes: LEARNER-10140
farhan-arshad-dev
force-pushed
the
farhan_ar/LEARNER-10140
branch
from
c5dc98c to
dc02f22
Compare
|
Hi @farhan-arshad-dev, these screenshots/contrast enhancements look great! It would be helpful to have more screenshots throughout the app for review, or ideally a build for testing against the proposed changes in Figma. |
Contributor
Author
|
Hi @sdaitzman, Apologies for the delay, I was occupied with some tasks. |
|
@farhan-arshad-dev sent on Slack, thank you!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Standardized button styling system in the app
Samples