feat: make staged static asset size limit configurable by site.#38670
feat: make staged static asset size limit configurable by site.#38670anfbermudezme wants to merge 1 commit into
Conversation
|
Thanks for the pull request, @anfbermudezme! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
1258d66 to
83738f1
Compare
83738f1 to
9ccda48
Compare
Description
This PR makes the static asset size limit used by content staging configurable through Site Configuration.
Today, static assets larger than 10 MB are not copied into staged content. Instead, the staged file record is still created with metadata such as
source_key_strandmd5_hash, but without storing the actualdata_file. This behavior is useful because staged files may be stored remotely, and uploading large assets can be slow or unnecessary when the asset can still be resolved from the source contentstore.This change preserves the existing 10 MB default, while allowing operators to override the threshold per site using:
{ "CONTENT_STAGING_STATIC_ASSET_SIZE_LIMIT_BYTES": 52428800 }The value is expressed in bytes. For example,
52428800sets the limit to 50 MB.Behavior
CONTENT_STAGING_STATIC_ASSET_SIZE_LIMIT_BYTESis not configured, the existing 10 MB limit is used.data_file, matching the current recovery/import behavior.Motivation
Some deployments need to support larger static assets during content staging workflows, especially when copying or syncing content that includes larger media or supporting files.
Making the limit configurable through Site Configuration keeps the default behavior unchanged for existing installations, while allowing operators to opt in to a higher or lower threshold without requiring a code change.
Scope
This PR intentionally keeps the change minimal:
Testing Notes
CONTENT_STAGING_STATIC_ASSET_SIZE_LIMIT_BYTESvalue changes the threshold used when staging static assets.data_file.