Added OPENEMR_GIT arg in Dockerfile to allow pulling from test forks …#613
Added OPENEMR_GIT arg in Dockerfile to allow pulling from test forks …#613luissantosHCIT wants to merge 7 commits intoopenemr:masterfrom
Conversation
…from test forks if specified otherwise pull from OpenEMR's repo. Signed-off-by: Luis M. Santos <lsantos@medicalmasses.com>
Signed-off-by: Luis M. Santos <lsantos@medicalmasses.com>
…cker Make git repo url an arg docker
kojiromike
left a comment
kojiromike
left a comment
There was a problem hiding this comment.
You may want to pause this to avoid conflicts, or keep an eye on #614, because the directory will be renamed soon.
| FROM base AS openemr-source | ||
| RUN git clone https://github.com/openemr/openemr.git --branch "${OPENEMR_VERSION}" --depth 1 \ | ||
| RUN git clone "${OPENEMR_GIT}" --branch "${OPENEMR_VERSION}" --depth 1 \ |
There was a problem hiding this comment.
On the off chance the repo name ends with something other than 'openemr', the directory created won't be named 'openemr'. So an explicit name would be good.
There was a problem hiding this comment.
I'll wait and update this once the other changes are merged. Thank you for the headsup!
One question (I am new to the project), why are the docker directories explicitly versioned as opposed to having a "latest" that gets backed up as the versioned directory prior to updating it further?
Thank you!
There was a problem hiding this comment.
good point @luissantosHCIT, that would be a simpler strategy to have the workflows use next and dev and then stamp them with the version upon release
it'll be worth thinking about moving there after we release 8.1.0 in about a month
…ny code databases available at target directory. The default directory is the contrib directory. Signed-off-by: Luis M. Santos <lsantos@medicalmasses.com>
…e_import_cli feature(auto-import-codes) Added script for automatically importing a…
…stream in Dockerfile Signed-off-by: Luis M. Santos <lsantos@medicalmasses.com>
3 participants
Fixes #612
Short description of what this resolves:
Allows builder tool to override which fork to pull from when building the OpenEMR image.
Changes proposed in this pull request:
OPENEMR_GITOPENEMR_GITto README