Skip to content

Add background color to selected device and app#530

Merged
rteyssandier merged 2 commits into
openflocon:mainfrom
snappdevelopment:selected-device-background
Jun 28, 2026
Merged

Add background color to selected device and app#530
rteyssandier merged 2 commits into
openflocon:mainfrom
snappdevelopment:selected-device-background

Conversation

@snappdevelopment

Copy link
Copy Markdown
Contributor

This is a small visual improvement to quickly see which device and app is currently selected when looking at the dropdown menu. When running multiple emulators or app variants it is sometimes hard to see which one is the one that is already selected, so I added a background color to make the selected one stand out a bit more.

image1

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces changes to highlight selected items in both the application and device dropdown menus by applying a background color when selected. The review feedback points out that using .run for conditional modifiers is not idiomatic in Jetpack Compose and suggests using Modifier.then() instead. Additionally, it highlights a semantic color mismatch and contrast issue where onTertiary (a content color) is used as a background color, recommending the use of primary instead to match the hardcoded onPrimary text color.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@rteyssandier rteyssandier added the enhancement New feature or request label Jun 28, 2026
@snappdevelopment snappdevelopment force-pushed the selected-device-background branch from 2057f03 to 1eecafb Compare June 28, 2026 10:07
@rteyssandier rteyssandier merged commit aa6320c into openflocon:main Jun 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants