Skip to content

Fix image filtering #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rteyssandier merged 2 commits into from
Jun 28, 2026
Merged

Fix image filtering #533

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce0fbb6
Fix image filtering
snappdevelopment Jun 28, 2026
bbd9098
Merge branch 'main' into fix-image-filter
snappdevelopment Jun 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...c/commonMain/kotlin/io/github/openflocon/flocondesktop/features/images/ImagesViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ class ImagesViewModel(

fun onFilterChanged(text: String) {
viewModelScope.launch(dispatcherProvider.viewModel) {
filter.emit(text)

@gemini-code-assist gemini-code-assist Bot Jun 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For MutableStateFlow, you can update the value synchronously using filter.value = text instead of calling the suspending emit(text) function. Furthermore, because updating a StateFlow's value is synchronous and thread-safe, you do not need to launch a coroutine via viewModelScope.launch at all. You should remove the coroutine wrapper and update the value directly.

Suggested change
filter.emit(text)
filter.value = text

}
}

Expand Down