Define Pydantic schema on Quantity#178
Draft
mattwthompson wants to merge 7 commits into
Draft
Conversation
mattwthompson
force-pushed
the
define-pydantic-schema
branch
2 times, most recently
from
a819b49 to
d09b154
Compare
Fixes Add Pydantic depedency to Python project metadata Update lockfile
mattwthompson
force-pushed
the
define-pydantic-schema
branch
from
a6b977c to
3b36116
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #178 +/- ##
==========================================
- Coverage 89.83% 84.82% -5.02%
==========================================
Files 6 6
Lines 187 224 +37
==========================================
+ Hits 168 190 +22
- Misses 19 34 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 tasks
for more information, see https://pre-commit.ci
…efine-pydantic-schema
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a possible solution for #177
and openforcefield/openff-interchange#1346 and arguably a better design from the ground-up than what we had in
openff-modelsTodos
Status