Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR "fixes" the crash in GSI 9.0 by removing
OIDExternalUserAgentiOS's call to[UIApplication sharedApplication] openURL:requestURL]. Since theASWebAuthenticationSessioncan be used for almost all sign-ins, the fallback is much less relevant.There is one caveat - Guided Access Mode. Before this change, the app would crash when attempting to open the external browser in Guided Access Mode. Now, it fails silently. While this is a strict improvement in behaviour, it offers no real way for AppAuth-iOS to be used by applications utilizing Guided Access Mode. I explored the new API Apple provided, and was unsuccessful in routing to a functioning browser. As this change is still an improvement over the current behaviour, I'll leave additional investigation for future work - filed as issue #953.
Testing: I've tested successful sign-in via the new Swift sample app. I also confirmed that Guided Access Mode replicates the crash; and that this change causes an internal error rather than a crash.