Skip to content

[MAINT] Run fewer services in CI - #1782

Merged
PGijsbers merged 3 commits into
mainfrom
maint/leaner-ci
Nov 3, 2026
Merged

PGijsbers merged 3 commits into
mainfrom
maint/leaner-ci

Conversation

@PGijsbers

@PGijsbers PGijsbers commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

We've made some changes to services lately which allows us to run fewer services, so this should decrease startup time.

@PGijsbers PGijsbers changed the title [MAINTRun fewer services in CI [MAINT] Run fewer services in CI Oct 23, 2026
@codecov-commenter

codecov-commenter commented Oct 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.91%. Comparing base (d35b799) to head (fb90c71).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1782   +/-   ##
=======================================
  Coverage   80.91%   80.91%           
=======================================
  Files          63       63           
  Lines        5230     5230           
=======================================
  Hits         4232     4232           
  Misses        998      998           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PGijsbers

Copy link
Copy Markdown
Member Author

Will update PR once openml/services#34 is merged.

@PGijsbers

Copy link
Copy Markdown
Member Author

Current issues:

  • tests still use url uploading, will be disbaled in [pre-commit.ci] pre-commit autoupdate #1783.
  • Windows tests use actual test server instead of services because the scripts setup steps don't work on windows. There seems to be a problematic tagging response from the test.openml.org elasticsearch instance, which seems out of scope for a fix in openml-python.

Comment on lines -127 to -132
echo "Waiting for PHP API to boot..."
timeout 60s bash -c 'until [ "$(docker inspect -f {{.State.Health.Status}} openml-php-rest-api)" == "healthy" ]; do sleep 5; done'

echo "Final Verification: Gateway Connectivity..."
curl -sSfL http://localhost:8000/api/v1/xml/data/1 | head -n 15

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docker compose would take a long time to start with the old setup since elastic search indexing needed to happen. I think this required a workaround to properly wait for services to be up. Either that or at some point a container which is supposed to exit gracefully during startup (e.g., database-setup) was included and this conflicts with --wait. Either way, with the new profile definition we don't have this issue and --wait works as expected.

@PGijsbers
PGijsbers merged commit 77d3e96 into main Nov 3, 2026
21 of 24 checks passed
@PGijsbers
PGijsbers deleted the maint/leaner-ci branch November 3, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants