Repository navigation
[MAINT] Run fewer services in CI - #1782
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1782 +/- ##
=======================================
Coverage 80.91% 80.91%
=======================================
Files 63 63
Lines 5230 5230
=======================================
Hits 4232 4232
Misses 998 998 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Will update PR once openml/services#34 is merged. |
7d58274 to
106bfac
Compare
|
Current issues:
|
| echo "Waiting for PHP API to boot..." | ||
| timeout 60s bash -c 'until [ "$(docker inspect -f {{.State.Health.Status}} openml-php-rest-api)" == "healthy" ]; do sleep 5; done' | ||
|
|
||
| echo "Final Verification: Gateway Connectivity..." | ||
| curl -sSfL http://localhost:8000/api/v1/xml/data/1 | head -n 15 | ||
|
|
There was a problem hiding this comment.
Docker compose would take a long time to start with the old setup since elastic search indexing needed to happen. I think this required a workaround to properly wait for services to be up. Either that or at some point a container which is supposed to exit gracefully during startup (e.g., database-setup) was included and this conflicts with --wait. Either way, with the new profile definition we don't have this issue and --wait works as expected.
We've made some changes to
serviceslately which allows us to run fewer services, so this should decrease startup time.