Repository navigation
[MNT] Mock ontology write requests in dataset tests - #1784
Open
Jayant-kernel wants to merge 2 commits into
Open
Jayant-kernel wants to merge 2 commits into
Jayant-kernel wants to merge 2 commits into
Conversation
20 tasks
Aadarshrai1801
approved these changes
Oct 29, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metadata
Details
The ontology tests write links to dataset 1, and the multiple-feature test leaves them behind. This replaces the four write cases with mocked HTTP requests so they can run offline without changing server data.
The tests check the add/remove endpoints, posted feature details, and handling of error codes 1105 and 1106. The error cases check the client's response handling; URL validation still belongs to the server.
Checked locally: all 5 offline tests in
test_dataset.pypass, along with pre-commit checks.