Support for Firefox sandboxed Uint8Array#23
Open
rrrooommmaaa wants to merge 1 commit intoopenpgpjs:mainfrom
Open
Support for Firefox sandboxed Uint8Array#23rrrooommmaaa wants to merge 1 commit intoopenpgpjs:mainfrom
rrrooommmaaa wants to merge 1 commit intoopenpgpjs:mainfrom
Conversation
5 tasks
5 tasks
Collaborator
|
Hey @rrrooommmaaa , pardon the late reply; we are considering merging this for the new release that will be used by OpenPGP.js v6. Does it not work to manually overwrite |
d0f6ef9 to
d8efe87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When loading OpenPGP.js 5.7.0 in a web content script in Firefox 112, it turned out
Uint8Array.prototype !== globalThis.Uint8Array.prototype, as a resultKey.armor()fails on a parsed key.This patch fixes the problem.