fix(git-info): stop stale polling after session replacement - #414
Open
627150795 wants to merge 1 commit into
Open
fix(git-info): stop stale polling after session replacement#414627150795 wants to merge 1 commit into
627150795 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After rapid session replacement, overlapping
session_starthandlers could leave polling fibers using an invalidated Pi context. The stale context was then accessed every five seconds and logged a background defect indefinitely.Value
Stop stale polling without affecting the newest session's refresh loop, and explicitly interrupt polling during session shutdown.
Approach
session_starthandlers after their previous-fiber interruption completes.Validation
bun run checknode --test --experimental-strip-types tests/extensions/git-info/index.test.ts tests/extensions/git-info/refresh-coordinator.test.tsThe full suite still has one pre-existing Windows failure in
tests/extensions/git-info/process.test.ts: a command exiting with code 7 is reported as -1.Impact
No public API changes. The change is limited to git-info background polling lifecycle and its regression coverage.