fix(workflows): follow Pi effective child idle timeout - #427
Closed
seekskyworld wants to merge 2 commits into
Closed
fix(workflows): follow Pi effective child idle timeout#427seekskyworld wants to merge 2 commits into
seekskyworld wants to merge 2 commits into
Conversation
Signed-off-by: seekskyworld <djh1813553759@gmail.com>
Signed-off-by: seekskyworld <djh1813553759@gmail.com>
Contributor
Author
|
No maintainer review comments were present on this PR. After it was opened, upstream merged #426 (#426, commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closes #425. Workflow child sessions derive their model-progress watchdog from raw optional
httpIdleTimeoutMsfields. When no override is configured, those fields are absent even though Pi's effective default is 300 seconds, so OpenPI can abort a healthy slow provider turn after 45 seconds. This is an independently reviewable reliability slice of #424; it does not claim to solve Cursor tool support, cross-directory authorization, or allowlist behavior.Value
Child provider turns now use the same effective idle-timeout contract as Pi's native transport. Unconfigured sessions no longer inherit an undocumented 45-second watchdog, while the bounded OpenPI guard remains in place for low values and an explicit transport timeout of
0.Approach
SettingsManager.getHttpIdleTimeoutMs()so Pi's merged settings and default are honored.docs/research/ISSUE_425_WORKFLOW_WATCHDOG_2026-09-07.md.Validation
npx --yes bun@1.3.14 run test— Node: 1430 passed, 1 skipped, 0 failed; Vitest: 30 passed.npx --yes bun@1.3.14 run typecheck— passed.npx --yes bun@1.3.14 run lint— passed.git diff --check— passed.npx --yes bun@1.3.14 run check— the repository check reaches the formatter and reports only the pre-existing untracked.golutra/local.jsonand.golutra/workspace.jsondifferences; config contract, discipline, Web syntax, lint, and typecheck pass. Those collaboration files were preserved.Impact
0retain the OpenPI floor. Cursor, workspace, and allowlist behavior are unchanged.