Open
Conversation
…stroy getFirstAddressField()
Author
|
With commit 1d961df the test in vcard_test.go line 59-80 cannot be done. I have no idea how to fix this and if it is important that VCardProperties can be converted in both ways... One could remove these tests, what is your opinion? |
…second lookup with the registrar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The coming ICANN Extensions for RDAP creates a new ADR parameter CC, this is the ISO 3166 two-character country code.
See also https://tools.ietf.org/html/rfc8605
Also the output has been modified to show the country code.
Second appendValueStrings did not work properly when ADR Values are arrays.