Skip SimplifyChainedAssertJAssertion when actual type has wildcard type parameters #906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pe parameters When the actual type (e.g. Map<?, ?>, Optional<?>, Collection<?>) has wildcard type parameters, the dedicated assertion methods may not accept concrete arguments due to captured wildcards. Skip the transformation whenever the dedicated assertion takes arguments and the actual type has any wildcard type parameters.
timtebeek
approved these changes
Feb 1, 2026
github-project-automation
bot
moved this from In Progress
to Ready to Review
in OpenRewrite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the actual type (e.g. Map, Optional, Collection) has
wildcard type parameters, the dedicated assertion methods may not accept
concrete arguments due to captured wildcards. Skip the transformation
whenever the dedicated assertion takes arguments and the actual type
has any wildcard type parameters.