Optimize get_script() using binary search for 42x speedup#156
Draft
Optimize get_script() using binary search for 42x speedup#156
Conversation
Co-authored-by: pudo <41628+pudo@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Identify and suggest improvements to slow or inefficient code
Optimize get_script() using binary search for 42x speedup
Jan 5, 2026
Member
|
@copilot I like this! Do we need to regenerate _SORTED_RANGES on each start or can we do this as the scripts data is computed in |
Co-authored-by: pudo <41628+pudo@users.noreply.github.com>
Author
Done in c908d6b. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_script()function using binary search (O(n) → O(log n) with 776 ranges)genscripts/generate_text.py)Performance Improvement
File:
rigour/text/scripts.pyIssue: The
get_script()function was iterating linearly through 776 Unicode script ranges to find the script for a codepoint. This is O(n) complexity for each lookup.Solution:
bisectmoduleSORTED_RANGESandRANGE_STARTSat code generation time ingenscripts/generate_text.pyrather than at module import timeBenchmark Results:
This optimization improves the performance of all functions that depend on script detection, including
can_latinize(),can_latinize_cp(), and indirectly affects name processing operations.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.