Skip to content

JPG/JPEG metadata removal#77

Merged
sadrasabouri merged 7 commits intodevfrom
add/jpeg_metadata
Apr 20, 2026
Merged

JPG/JPEG metadata removal#77
sadrasabouri merged 7 commits intodevfrom
add/jpeg_metadata

Conversation

@AHReccese
Copy link
Copy Markdown
Member

@AHReccese AHReccese commented Apr 18, 2026

Reference Issues/PRs

#50

  • JPG/JPEG metadata removal based on jpeg standard
    (for bytes and markers pattern, stable structure for over 30 years)

What does this implement/fix? Explain your changes.

Any other comments?

@AHReccese AHReccese self-assigned this Apr 18, 2026
@AHReccese AHReccese added this to the DMeta v0.5 milestone Apr 18, 2026
@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented Apr 18, 2026

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

@AHReccese AHReccese marked this pull request as ready for review April 18, 2026 22:53
@AHReccese
Copy link
Copy Markdown
Member Author

@sadrasabouri
Hi Sadra,
Review this PR, after #76 so we have MacOS tests result as well. For README and CLI, I will ship another PRs after adding gif support to reflect end-to-end integration of image formats into DMeta.

Also, parsing of JPG bytes, is based on its standard (stable for decades), and I had technical reasons for not using PIL here (unlike png case).

Best,
AmirH

@AHReccese AHReccese requested a review from sadrasabouri April 18, 2026 22:57
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 68.75000% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.97%. Comparing base (cc908a2) to head (f8b3cf3).

Files with missing lines Patch % Lines
dmeta/functions.py 63.42% 9 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #77      +/-   ##
==========================================
- Coverage   72.77%   69.97%   -2.80%     
==========================================
  Files           5        5              
  Lines         235      283      +48     
  Branches       58       69      +11     
==========================================
+ Hits          171      198      +27     
- Misses         42       55      +13     
- Partials       22       30       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@sadrasabouri sadrasabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed and tested it. It's working perfectly.

@sadrasabouri sadrasabouri merged commit 2b04be1 into dev Apr 20, 2026
22 checks passed
@sadrasabouri sadrasabouri deleted the add/jpeg_metadata branch April 20, 2026 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants