Skip to content

GIFF metadata removal#79

Merged
sadrasabouri merged 6 commits intodevfrom
add/gif
Apr 23, 2026
Merged

GIFF metadata removal#79
sadrasabouri merged 6 commits intodevfrom
add/gif

Conversation

@AHReccese
Copy link
Copy Markdown
Member

@AHReccese AHReccese commented Apr 20, 2026

Reference Issues/PRs

#50

What does this implement/fix? Explain your changes.

GIFF metadata removal based on gif standard
(for bytes and markers pattern, stable structure for over decades)

Any other comments?

@AHReccese AHReccese added this to the DMeta v0.5 milestone Apr 20, 2026
@AHReccese AHReccese self-assigned this Apr 20, 2026
@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented Apr 20, 2026

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes. Give us feedback

@AHReccese AHReccese marked this pull request as ready for review April 20, 2026 22:22
@AHReccese AHReccese requested a review from sadrasabouri April 20, 2026 22:22
@AHReccese AHReccese linked an issue Apr 20, 2026 that may be closed by this pull request
3 tasks
@AHReccese AHReccese changed the title GIF metadata removal GIFF metadata removal Apr 20, 2026
Copy link
Copy Markdown
Member

@sadrasabouri sadrasabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and it works fine. I left a minor comment. We should update the cli help when updating readme as well.

Comment thread dmeta/functions.py Outdated
Comment on lines +402 to +403
elif label in (GIF_EXT_COMMENT, GIF_EXT_PLAIN_TEXT):
i = skip_sub_blocks(i + 2)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this condition is extra since you have the same thing for else.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I understand. That was due to the standard requiring different parts to be parsed separately, so I simplified it for now.
But once I add the update functionality, I’ll need to break it down again later on.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 22, 2026

Codecov Report

❌ Patch coverage is 80.88235% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.08%. Comparing base (cc908a2) to head (916fb30).
⚠️ Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
dmeta/functions.py 79.04% 6 Missing and 7 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #79      +/-   ##
==========================================
- Coverage   72.77%   72.08%   -0.68%     
==========================================
  Files           5        5              
  Lines         235      351     +116     
  Branches       58       84      +26     
==========================================
+ Hits          171      253      +82     
- Misses         42       61      +19     
- Partials       22       37      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sadrasabouri sadrasabouri merged commit 6173207 into dev Apr 23, 2026
22 checks passed
@sadrasabouri sadrasabouri deleted the add/gif branch April 23, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add support for PNG | JPG | GIFF file formats

3 participants