GIFF metadata removal#79
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes. Give us feedback
sadrasabouri
left a comment
There was a problem hiding this comment.
I tested it and it works fine. I left a minor comment. We should update the cli help when updating readme as well.
| elif label in (GIF_EXT_COMMENT, GIF_EXT_PLAIN_TEXT): | ||
| i = skip_sub_blocks(i + 2) |
There was a problem hiding this comment.
this condition is extra since you have the same thing for else.
There was a problem hiding this comment.
Yeah, I understand. That was due to the standard requiring different parts to be parsed separately, so I simplified it for now.
But once I add the update functionality, I’ll need to break it down again later on.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #79 +/- ##
==========================================
- Coverage 72.77% 72.08% -0.68%
==========================================
Files 5 5
Lines 235 351 +116
Branches 58 84 +26
==========================================
+ Hits 171 253 +82
- Misses 42 61 +19
- Partials 22 37 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Reference Issues/PRs
#50
What does this implement/fix? Explain your changes.
GIFF metadata removal based on gif standard
(for bytes and markers pattern, stable structure for over decades)
Any other comments?