Skip to content

Comments

[Backport] [3.x] Update Specification and Re-generate Code (#1890)#1894

Merged
reta merged 1 commit intoopensearch-project:3.xfrom
reta:backport/backport-1890-to-3.x
Feb 23, 2026
Merged

[Backport] [3.x] Update Specification and Re-generate Code (#1890)#1894
reta merged 1 commit intoopensearch-project:3.xfrom
reta:backport/backport-1890-to-3.x

Conversation

@reta
Copy link
Collaborator

@reta reta commented Feb 22, 2026

Backport of #1890 to 3.x

Signed-off-by: Andriy Redko <drreta@gmail.com>
(cherry picked from commit 779e31a)
Signed-off-by: Andriy Redko <drreta@gmail.com>
@reta reta force-pushed the backport/backport-1890-to-3.x branch from e772791 to 22784c0 Compare February 22, 2026 22:24

@Nonnull
private final List<ShardFailure> failures;
private final List<ShardSearchFailure> failures;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is technically a breaking change for 3.x

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Xtansia . Yes, it is, sadly, we have discussed it over here #1877 (comment), I honestly unsure what would be the best option here:

  • revert ShardFailure changes for primary etc
  • or adsorb this breaking change (since ShardSearchFailure will never have primary populated, it is never returned by the server)

@reta reta merged commit c91e743 into opensearch-project:3.x Feb 23, 2026
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants