Repository navigation
fix(engine): take Bun's NSS 3.131.1 roots and blocked-key check - #222
Merged
Merged
Conversation
Ports oven-sh/bun#46300 onto the pinned engine as one more patch in patches/bun.patch: certificate chains holding a public key on Node's blocked list fail verification, and the bundled roots are NSS 3.131.1. The other 26 patches are unchanged.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Adds oven-sh/bun#46300 (in Bun 1.4.4) to the engine patch series:
CERT_REVOKED.Node shipped the same change in 22.23.4, 24.22.1 and 26.12.1.
How it was ported
It is one patch appended to
patches/bun.patch. The other 26 patches are byte-for-byte unchanged.The pinned engine is ten upstream TLS commits behind #46300, so the cherry-pick conflicted. The port keeps only:
blocked_spkis.cpp, from upstream as is);It leaves out
selectServerNameand the self-issued leaf rule (upstream #44365), which came with those later commits.The check runs everywhere the pinned engine verifies a chain:
us_cert_verify_cb, set on every SSL context that usockets builds (node:tls,node:https,fetch, WebSocket);quic.c, which verifies chains itself forfetchover HTTP/3;node:quic's own SSL context.How it was tested
git amof the new series on the pinned commit gives the same tree as the port branch.tls.rootCertificates.lengthis 118.node:tlsandfetchboth fail withCERT_REVOKED.DEPTH_ZERO_SELF_SIGNED_CERTfor the same server.bun:internal-for-testing, which release builds do not have, or a certificate issued under the blocked CA.Checklist
npm run checkis clean and./test.shpasses (patch file only)bench/are above (to do before the release: one SHA-256 per certificate per handshake)CHANGELOG.mdedits