Skip to content

[WIP] Fix code based on review comment#432

Merged
matteius merged 1 commit into
mainfrom
copilot/fix-review-comment
Jun 5, 2026
Merged

[WIP] Fix code based on review comment#432
matteius merged 1 commit into
mainfrom
copilot/fix-review-comment

Conversation

Copilot AI commented Jun 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Fix sub-stream registration in go2rtc_integration_register_stream() (line ~1951):
    • Use config.record_audio instead of hardcoded value for the record_audio parameter
    • Check and log the return value of go2rtc_stream_register consistently with the main stream registration
    • Propagate sub-stream failure to the return value so callers can detect incomplete registration

@matteius matteius marked this pull request as ready for review June 5, 2026 11:23
@matteius matteius merged commit 60d6e16 into main Jun 5, 2026
2 of 3 checks passed
Copilot stopped work on behalf of matteius due to an error June 5, 2026 11:24
The session was cancelled by the user.
Copilot AI requested a review from matteius June 5, 2026 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matteius matteius Awaiting requested review from matteius

Assignees

@matteius matteius

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matteius