H264/MP4 Mux/Demux Fixes - #218
Merged
nickgaray merged 10 commits intoJul 24, 2026
Merged
Conversation
Cardy2
reviewed
Jul 2, 2026
Cardy2
reviewed
Jul 2, 2026
Cardy2
suggested changes
Jul 2, 2026
Cardy2
approved these changes
Jul 22, 2026
Cardy2
left a comment
Contributor
There was a problem hiding this comment.
I'll just re-add what I messaged you about here:
I re-tested it and everything works. I dont think they're blockers but just curious if we should document 2 things:
1.) We intentionally drop the SEI in filtering pass_types=1|5 - if we need that metadata in the future we should add 6?
2.) Parameter-set injection relies on demuxer keyframe flags: AV_PKT_FLAG_KEY is assumed to be correctly given from the source otherwise the parameter sets will not be reinjected by dump_extra
Those things might be obvious but I just wanted to see if you had thought about them?
Otherwise, good to go.
nickgaray
reviewed
Jul 23, 2026
nickgaray
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FFmpeg driver now no longer manually converts and inserts extradata on each key frame. Instead, it relies on FFmpeg's bitstream filters.