promote OSStreams to GA in self-managed clusters

[cheesesashimi]

This promotes the OSStream feature to GA for self-managed clusters. The intent behind this is that we will be able to begin testing OCP on RHEL10 since OSStreams helps make that possible. This PR purposely avoids default enablement in Hypershift as there are some unknowns and must-have conversations around that.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

Hello @cheesesashimi! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 8ddcaac3-9d5a-4214-8d8c-4481576617e8

📥 Commits

Reviewing files that changed from the base of the PR and between dcaca8e and e00a624.

📒 Files selected for processing (3)

• features.md
• features/features.go
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml

---

📝 Walkthrough

Walkthrough

This PR enables the OSStreams feature gate for two cluster configurations. The feature gate logic in features/features.go is updated to conditionally enable OSStreams for SelfManaged clusters with Default configuration (including inDefault() alongside preview-no-upgrade conditions) and for Hypershift clusters (with only preview-no-upgrade conditions). The feature gate manifest for SelfManagedHA-Default moves OSStreams from the disabled list to the enabled list, and the features documentation table is updated to reflect this enablement status.

🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Test Structure And Quality	⚠️ Warning	tests/suite_test.go added with Ginkgo code violates timeouts and assertion message requirements: no timeout on cluster operations and assertions lack descriptive messages.	Add context timeout to BeforeSuite for cluster operations. Add descriptive messages to Expect assertions, e.g., Expect(cfg).NotTo(BeNil(), 'config should not be nil').

✅ Passed checks (11 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'promote OSStreams to GA in self-managed clusters' accurately reflects the main changes: promoting OSStreams feature to GA status specifically for self-managed clusters.
Description check	✅ Passed	The description is directly related to the changeset, explaining the motivation (enabling OCP on RHEL10 testing) and deliberate design choice (excluding Hypershift).
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR modifies only feature gate configs and documentation. No Ginkgo test files or test names were changed. Existing test names use static descriptive strings.
Microshift Test Compatibility	✅ Passed	This PR does not add any new Ginkgo e2e tests. It only modifies configuration files (features.md, features.go, and YAML manifests), so the MicroShift test compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR contains no new Ginkgo e2e tests—only feature gate configuration and documentation updates. The SNO compatibility check does not apply.
Topology-Aware Scheduling Compatibility	✅ Passed	PR only modifies feature gate configuration and documentation, not deployment manifests, operator code, or controllers. No scheduling constraints introduced.
Ote Binary Stdout Contract	✅ Passed	PR changes feature gate configurations (features.go, features.md, YAML manifests) with no OTE test binaries, main() entry points, or stdout writes. Check not applicable.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added in this commit. The check is not applicable since it only applies to newly added tests.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sdodson]

/test ci/prow/verify-feature-promotion

[sdodson]

/test verify-feature-promotion

[openshift-ci]

@cheesesashimi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-feature-promotion	e00a624	link	true	/test verify-feature-promotion

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.