Skip to content

Added GINKGO_LABEL_FILTER env variable to run-test.sh #1464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SargunNarula wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added GINKGO_LABEL_FILTER env variable to run-test.sh #1464

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion hack/run-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,15 @@ main() {
NO_COLOR="--no-color"
fi

LABEL_FILTER_FLAG=""
Copy link
Copy Markdown
Contributor

@Tal-or Tal-or Feb 23, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we just use the EXTRA_PARAMS flag?
If we do, no code change are needed

if [ -n "$GINKGO_LABEL_FILTER" ]; then
LABEL_FILTER_FLAG="--label-filter=${GINKGO_LABEL_FILTER}"
fi

MESSAGE="${HEADER_MESSAGE}: ${GINKGO_SUITS}"
print ${MESSAGE}

GINKGO_FLAGS="${NO_COLOR} ${DRY_RUN} ${EXTRA_PARAMS} --require-suite ${REPORT_PARAMS} ${GINKGO_SUITS}"
GINKGO_FLAGS="${NO_COLOR} ${DRY_RUN} ${EXTRA_PARAMS} ${LABEL_FILTER_FLAG} --require-suite ${REPORT_PARAMS} ${GINKGO_SUITS}"
print "Command to run: GOFLAGS=-mod=vendor ginkgo ${GINKGO_FLAGS}"

if [ "$ONLY_CLI_PRINT" = true ]; then
Expand Down