Periodic sync of OKD samples#683
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughBump Open Liberty ImageStream tags to 26.0.0.5 for Java 8/11/17/21; replace Node.js 20 tags with Node.js 22 variants for UBI8/UBI9; add PHP 8.4 on UBI10 ImageStream tag; set explicit Rails and PostgreSQL container images in deployment templates. ChangesImageStream & template updates
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (11 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aroyoredhat The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
assets/operator/okd-x86_64/openliberty/imagestreams/openliberty.json (1)
17-99:⚠️ Potential issue | 🔴 CriticalThe Docker images for Open Liberty 26.0.0.3 do not exist at the specified registry and must be available before merge.
All four referenced images (26.0.0.3-java8, java11, java17, java21) at
icr.io/appcafe/open-liberty-s2iare inaccessible and will cause deployment failures. Either push these images to the registry or revert the version references to available images.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@assets/operator/okd-x86_64/openliberty/imagestreams/openliberty.json` around lines 17 - 99, The image stream entries named "26.0.0.3-java8", "26.0.0.3-java11", "26.0.0.3-java17", and "26.0.0.3-java21" reference non-existent images in the from.name fields (e.g. "icr.io/appcafe/open-liberty-s2i:26.0.0.3-java8") and must be fixed; either push the corresponding images to icr.io with those tags or update each from.name to a confirmed available tag (or revert the name fields back to the last-known-working tag) and ensure the display name annotations (openshift.io/display-name) stay consistent, then verify by doing a docker pull of each updated from.name.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@assets/operator/okd-x86_64/openliberty/imagestreams/openliberty.json`:
- Around line 17-99: The image stream entries named "26.0.0.3-java8",
"26.0.0.3-java11", "26.0.0.3-java17", and "26.0.0.3-java21" reference
non-existent images in the from.name fields (e.g.
"icr.io/appcafe/open-liberty-s2i:26.0.0.3-java8") and must be fixed; either push
the corresponding images to icr.io with those tags or update each from.name to a
confirmed available tag (or revert the name fields back to the
last-known-working tag) and ensure the display name annotations
(openshift.io/display-name) stay consistent, then verify by doing a docker pull
of each updated from.name.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 7a8aae5f-ff07-4d07-8575-f3ac59b443f6
📒 Files selected for processing (1)
assets/operator/okd-x86_64/openliberty/imagestreams/openliberty.json
aa6d064 to
e43e0f0
Compare
e43e0f0 to
7cf53e6
Compare
7cf53e6 to
48571eb
Compare
48571eb to
7a08d32
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@assets/operator/okd-x86_64/openliberty/imagestreams/openliberty.json`:
- Line 29: The Open Liberty ImageStream tag
"icr.io/appcafe/open-liberty-s2i:26.0.0.5-java8" (and the sibling tags for
java11/java17/java21) points to a release affected by CVE-2026-5516; update
these ImageStream entries to reference a fixed release (e.g., change tags to
"26.0.0.6" or later) or annotate the tags to require applying the interim
fix/APAR PH70798 (Liberty fix pack 26.0.0.6+) so consumers will use a remediated
image; locate and update the string constants for
"open-liberty-s2i:26.0.0.5-java8" (and the corresponding java11/java17/java21
tags) in the ImageStream JSON and ensure all tag variants are consistently
updated.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 140320fa-0769-480f-95dd-b104699080e2
📒 Files selected for processing (4)
assets/operator/okd-x86_64/nodejs/imagestreams/nodejs-centos.jsonassets/operator/okd-x86_64/openliberty/imagestreams/openliberty.jsonassets/operator/okd-x86_64/php/imagestreams/php-centos.jsonassets/operator/okd-x86_64/rails/templates/rails-pgsql-persistent.json
💤 Files with no reviewable changes (1)
- assets/operator/okd-x86_64/nodejs/imagestreams/nodejs-centos.json
✅ Files skipped from review due to trivial changes (1)
- assets/operator/okd-x86_64/php/imagestreams/php-centos.json
df76428 to
35cee2a
Compare
35cee2a to
b75f9be
Compare
|
@aroyoredhat: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Syncing the latest samples from the library to OKD.
Created using https://github.com/aroyoredhat/trigger-test-samples-build