CORS-4316: Update the Installer GCP UPI documentation.#10235
CORS-4316: Update the Installer GCP UPI documentation.#10235barbacbd wants to merge 1 commit intoopenshift:mainfrom
Conversation
|
@barbacbd: This pull request references CORS-4316 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cc @jianli-wei |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
4d238d0 to
9a4ab2b
Compare
9a4ab2b to
0782f19
Compare
|
/retest-required |
|
/retest |
0782f19 to
51b2283
Compare
51b2283 to
ee30935
Compare
|
/test e2e-gcp-upi-xpn |
docs/user/gcp/install_upi.md
Outdated
There was a problem hiding this comment.
Should we define a default instance type and disk size like we did before?
machine_type: 'n1-standard-4'
root_volume_size: '128'
Or similar to https://github.com/openshift/release/blob/master/ci-operator/step-registry/upi/install/gcp/upi-install-gcp-ref.yaml?
tthvo
left a comment
There was a problem hiding this comment.
It takes quite a lot of efforts but I got the install correctly following this new doc. There are a few more questions/comments above, but overall, it looks good 👍
|
@jianli-wei It's unrelated to this PR, but I ran ci/prow/e2e-gcp-upi-xpn to cross-reference the commands. It seems like there is a mismatch in region between the subnet's region and the gcloud cli |
** Change the documentation to reference pure bash. The deployment manager is EOL in March 2026. Design Choices: 1. Terraform: The deployment manager can be converted to terraform. The installer team already removed terraform, so there is no reason to go back to using terraform. 2. KRM: The deployment manager can be converted to use kubectl. This did not work, because very few resources do not have an equivalent in kubectl (but we use those resources). 3. CI uses pure bash now, so this will remain consistent. Note: The python templates are not removed in this commit. They are still found in upi/gcp/
ee30935 to
ec42623
Compare
There was a problem hiding this comment.
| gcloud compute instances create ${INFRA_ID}-${machine_role}-${index} --boot-disk-size=${WORKER_DISK_SIZE} --boot-disk-type=${WORKER_DISK_TYPE} --image=${CLUSTER_IMAGE} --metadata=^#^user-data="${WORKER_IGNITION}" --machine-type=${WORKER_MACHINE_TYPE} --zone=${zone} --no-address --service-account=${WORKER_SERVICE_ACCOUNT} --scopes=https://www.googleapis.com/auth/cloud-platform --tags=${INFRA_ID}-${machine_role} --subnet=${COMPUTE_SUBNET} |
I think WORKER_DISK_SIZE already has the suffix GB, right? ${WORKER_DISK_SIZE}GB will produce 128GBGB...
|
@barbacbd: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
I didn't realize UPI was being converted to Bash. We can discuss with PM, but I have some concerns about this direction: using Bash seems like it might be difficult to maintain and to convert into our docs structure. Deployment Manager is being replaced by Infrastructure Manager, which uses HCL/Terraform Templates. I thought we were aligned on using that, so let's regroup and discuss this. |
** Change the documentation to reference pure bash. The deployment manager is EOL in March 2026.
Design Choices:
Note: The python templates are not removed in this commit. They are still found in upi/gcp/