CORS-4244: adjust validations to allow dual-stack CIDRs on AWS#10241
CORS-4244: adjust validations to allow dual-stack CIDRs on AWS#10241tthvo wants to merge 2 commits intoopenshift:mainfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@tthvo: This pull request references CORS-4244 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label platform/aws |
openshift-ci
bot
requested review from
barbacbd,
patrickdillon and
yunjiang29
|
/test golint |
|
/test e2e-metal-ipi-ovn-ipv6 e2e-metal-ipi-ovn-dualstack e2e-openstack-dualstack |
|
/test e2e-aws-ovn |
|
/approve e2e-aws-ovn is failing due to openstack-installer-amd64 failing. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sadasu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required |
|
In the latest commits, I added a validation to catch the case: |
Adjust the static validation to allow defining both IPv4 and IPv6 CIDR entries for clusterNetwork, serviceNetwork and machineNetwork. Note: for AWS, the IPv6 machineNetwork CIDR may not be available in advance. For example, if the installer creates the VPC, the IPv6 CIDR by default is allocated automatically by AWS.
|
New changes are detected. LGTM label has been removed. |
|
@tthvo: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
Adjust the static validation to allow defining both IPv4 and IPv6 CIDR entries for
clusterNetwork,serviceNetworkandmachineNetworkonly ifplatform.aws.ipFamilyis specified asDualStackIPv4PrimaryorDualStackIPv6Primary.Additional details
For AWS, the IPv6
machineNetworkCIDR may not be available in advance (i.e. before infra provisioning). For example, if the installer creates the VPC, the IPv6 CIDR by default is allocated automatically by AWS.