Skip to content

OLS-2645: Go Module updates#1289

Open
raptorsun wants to merge 9 commits intoopenshift:mainfrom
raptorsun:deps-1
Open

OLS-2645: Go Module updates#1289
raptorsun wants to merge 9 commits intoopenshift:mainfrom
raptorsun:deps-1

Conversation

@raptorsun
Copy link
Contributor

@raptorsun raptorsun commented Feb 17, 2026 •
edited
Loading

Description

This PR requires to merge the CI config PR together openshift/release#74997

Go module updates:

  • github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring to v0.89.0
  • k8s to 0.35.1
  • openshift API to 20260213141500-06efc6dce93b
  • go-openapi to 0.25.4
  • github.com/google/pprof digest to cb029da
  • update module github.com/prometheus/common to v0.67.5 + asset generation with new structure of monitoring CRD
  • update module gopkg.in/evanphx/json-patch.v4 to v4.13.0

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@raptorsun
deps: update module gopkg.in/evanphx/json-patch.v4 to v4.13.0
719e898 
Signed-off-by: Haoyu Sun <hasun@redhat.com>
@raptorsun
deps: update module github.com/prometheus/common to v0.67.5
a315c10 
Signed-off-by: Haoyu Sun <hasun@redhat.com>
@raptorsun
deps: update k8s.io/utils digest to b8788ab
7defba2 
Signed-off-by: Haoyu Sun <hasun@redhat.com>
@raptorsun
deps: github.com/google/pprof digest to cb029da
194605f 
Signed-off-by: Haoyu Sun <hasun@redhat.com>
@raptorsun
deps: update go-openapi to 0.25.4
5390819 
Signed-off-by: Haoyu Sun <hasun@redhat.com>
@raptorsun
deps: update k8s and openshift API packages to 0.35.1 and 20260213141…
0ad0625 
…500-06efc6dce93b

Signed-off-by: Haoyu Sun <hasun@redhat.com>
@raptorsun
deps: update github.com/prometheus-operator/prometheus-operator/pkg/a…
d41e8fc 
…pis/monitoring to v0.89.0

Signed-off-by: Haoyu Sun <hasun@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 17, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 17, 2026 •
edited by openshift-ci bot
Loading

@raptorsun: This pull request references OLS-2645 which is a valid jira issue.

Details

In response to this:

Description

Go module updates:

  • github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring to v0.89.0
  • k8s to 0.35.1
  • openshift API to 20260213141500-06efc6dce93b
  • go-openapi to 0.25.4
  • github.com/google/pprof digest to cb029da
  • update module github.com/prometheus/common to v0.67.5 + asset generation with new structure of monitoring CRD
  • update module gopkg.in/evanphx/json-patch.v4 to v4.13.0

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from bparees and xrajesh February 17, 2026 15:14
@raptorsun raptorsun mentioned this pull request Feb 17, 2026
Merged
@raptorsun
ci: build_root_image set to go 1.25
a455410 
Signed-off-by: Haoyu Sun <hasun@redhat.com>
@raptorsun
conf: golang ci config file convert to version 2 format
823d771 
Signed-off-by: Haoyu Sun <hasun@redhat.com>
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 17, 2026 •
edited by openshift-ci bot
Loading

@raptorsun: This pull request references OLS-2645 which is a valid jira issue.

Details

In response to this:

Description

This PR requires to merge the CI config PR together openshift/release#74997

Go module updates:

  • github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring to v0.89.0
  • k8s to 0.35.1
  • openshift API to 20260213141500-06efc6dce93b
  • go-openapi to 0.25.4
  • github.com/google/pprof digest to cb029da
  • update module github.com/prometheus/common to v0.67.5 + asset generation with new structure of monitoring CRD
  • update module gopkg.in/evanphx/json-patch.v4 to v4.13.0

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

xrajesh
xrajesh reviewed Feb 17, 2026
View reviewed changes
internal/controller/appserver/assets.go
ServerName: &serverName,
},
},
HTTPConfigWithoutTLS: monv1.HTTPConfigWithoutTLS{
Copy link
Contributor

@xrajesh xrajesh Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raptorsun Do we need this HTTPConfigWithoutTLS ? When is this used ?

Copy link
Contributor Author

@raptorsun raptorsun Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTTPConfigWithoutTLS is part of the HTTPConfigWithProxyAndTLSFiles structure, containing authroization configs

Copy link
Contributor Author

@raptorsun raptorsun Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is technically the same config as before, just reformatted in the new structure of ServiceMonitor CR

@xrajesh
Copy link
Contributor

xrajesh commented Feb 18, 2026

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2026
@openshift-ci
Copy link

openshift-ci bot commented Feb 18, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrajesh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2026
This was referenced Feb 18, 2026
Closed
Closed
Closed
Closed
Closed
Open
Open
Closed
This was referenced Feb 18, 2026
Open
Open
@raptorsun
Copy link
Contributor Author

raptorsun commented Feb 18, 2026

/retest

1 similar comment
@raptorsun
Copy link
Contributor Author

raptorsun commented Feb 18, 2026

/retest

@openshift-ci
Copy link

openshift-ci bot commented Feb 18, 2026

@raptorsun: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/lint 823d771 link true /test lint
ci/prow/bundle-e2e-4-20 823d771 link true /test bundle-e2e-4-20

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xrajesh xrajesh xrajesh left review comments

@bparees bparees Awaiting requested review from bparees

Assignees

@xrajesh xrajesh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@raptorsun @openshift-ci-robot @xrajesh

Comments