OCPBUGS-92832: Fix test 60835 cascading failures by adding thinPoolConfig to vg2

[kasturinarra]

Summary

• Test 60835 (createWithMultiDeviceClasses) creates an LVMCluster with two device classes but omits thinPoolConfig on vg2
• On release-4.14, thinPoolConfig is a required field (+kubebuilder:validation:Required), so the webhook rejects the create with: spec.storage.deviceClasses[1].thinPoolConfig: Required value
• Because test 60835 is [Disruptive] and deletes the original LVMCluster first, the failed create leaves no LVMCluster on the cluster, causing all subsequent tests to skip with "LVMS Operator is not installed"
• This fix adds thinPoolConfig with thin-pool-2 to the vg2 device class, matching the template used in openshift-tests-private (lvmcluster-with-multi-thinpool-template.yaml) for the same test

Root Cause

• On main/4.16+, thinPoolConfig is +optional (thick provisioning is supported)
• On release-4.14, it is +required — the test was written for the newer API but the manifest is invalid on 4.14

Test plan

• Verify BM MNO integration tests pass without cascading skips after test 60835
• Confirm both storage classes (lvms-vg1, lvms-vg2) are created successfully

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 7c4c82e8-db3d-49e2-b258-495c39657a39

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci-robot]

@kasturinarra: This pull request references Jira Issue OCPBUGS-92832, which is invalid:

• expected the bug to target the "4.14.z" version, but no target version was set
• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-92832 to depend on a bug targeting a version in 4.15.0, 4.15.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

• Test 60835 (createWithMultiDeviceClasses) creates an LVMCluster with two device classes but omits thinPoolConfig on vg2
• On release-4.14, thinPoolConfig is a required field (+kubebuilder:validation:Required), so the webhook rejects the create with: spec.storage.deviceClasses[1].thinPoolConfig: Required value
• Because test 60835 is [Disruptive] and deletes the original LVMCluster first, the failed create leaves no LVMCluster on the cluster, causing all subsequent tests to skip with "LVMS Operator is not installed"
• This fix adds thinPoolConfig with thin-pool-2 to the vg2 device class, matching the template used in openshift-tests-private (lvmcluster-with-multi-thinpool-template.yaml) for the same test

Root Cause

• On main/4.16+, thinPoolConfig is +optional (thick provisioning is supported)
• On release-4.14, it is +required — the test was written for the newer API but the manifest is invalid on 4.14

Test plan

• Verify BM MNO integration tests pass without cascading skips after test 60835
• Confirm both storage classes (lvms-vg1, lvms-vg2) are created successfully

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kasturinarra
Once this PR has been reviewed and has the lgtm label, please assign brandisher for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.22%. Comparing base (2137ff5) to head (e5e4c14).
⚠️ Report is 13 commits behind head on release-4.14.

Additional details and impacted files

@@              Coverage Diff              @@
##           release-4.14    #2767   +/-   ##
=============================================
  Coverage         17.22%   17.22%           
=============================================
  Files                24       24           
  Lines              2108     2108           
=============================================
  Hits                363      363           
  Misses             1718     1718           
  Partials             27       27           

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[kasturinarra]

/test nightly-images

[openshift-ci]

@kasturinarra: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.