ROSA-745: boilerplate-update and enable MintMaker gomod#555
ROSA-745: boilerplate-update and enable MintMaker gomod#555MitaliBhalla wants to merge 1 commit into
Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
WalkthroughThe pull request updates ChangesRenovate Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error, 3 warnings)
✅ Passed checks (11 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci-robot
added
the
jira/valid-reference
|
@MitaliBhalla: This pull request references ROSA-745 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the initiative to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MitaliBhalla The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/retest-required |
1 similar comment
|
/retest-required |
MitaliBhalla
force-pushed
the
rosa-745-mintmaker-gomod
branch
from
9699e0d to
f27ecfa
Compare
|
/retest-required |
1 similar comment
|
/retest-required |
|
can see you've closed the previous #554 and created this new #555 , could you clarify a bit why #554 was closed and replaced by #555?
|
| "extends": [ | ||
| "github>openshift/boilerplate//.github/renovate.json" | ||
| ], | ||
| "enabledManagers": [ |
There was a problem hiding this comment.
Does this MCVW really needs this explicitly for MintMaker gomod to run, instead of relying only on the inherited boilerplate renovate config?
as you mentioned earlier pagerduty-operator was used as a reference case, but I want to understand whether this is a `Renovate/MintMaker merge behavior or a rollout workaround?
|
btw, can see we have one konflux CI job failed, once we understand the reduced scope in this new #555 and CI it's green, it should be much easier to review. |
MitaliBhalla
force-pushed
the
rosa-745-mintmaker-gomod
branch
from
f27ecfa to
e2896c8
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/renovate.json:
- Around line 6-8: You have duplicate dependency management for Go modules: the
`gomod` manager is enabled in Renovate's enabledManagers configuration, and
`.github/dependabot.yml` also has an active `gomod` package-ecosystem entry.
This causes both tools to create separate PRs for the same dependencies. Choose
one tool to manage Go module dependencies and disable it in the other. Either
remove `gomod` from the enabledManagers array in the Renovate configuration, or
remove the gomod package-ecosystem entry from the Dependabot configuration—pick
one tool to be the single source of truth for gomod updates.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 3a9f0c87-0a2b-4d47-a6a7-57b27a067cb0
⛔ Files ignored due to path filters (2)
boilerplate/_data/last-boilerplate-commitis excluded by!boilerplate/**boilerplate/_lib/subscriber-propose-updateis excluded by!boilerplate/**
📒 Files selected for processing (1)
.github/renovate.json
| "enabledManagers": [ | ||
| "tekton", | ||
| "gomod" |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Read-only check for potential duplicate gomod automation across Renovate and Dependabot.
set -euo pipefail
echo "== Renovate managers =="
if [ -f .github/renovate.json ]; then
sed -n '1,200p' .github/renovate.json | nl -ba
else
echo ".github/renovate.json not found"
fi
echo
echo "== Dependabot gomod entries (if any) =="
if [ -f .github/dependabot.yml ]; then
nl -ba .github/dependabot.yml | sed -n '1,260p'
echo
rg -n -C3 'package-ecosystem:\s*"gomod"|package-ecosystem:\s*gomod' .github/dependabot.yml || true
else
echo ".github/dependabot.yml not found"
fiRepository: openshift/managed-cluster-validating-webhooks
Length of output: 174
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== Renovate configuration (.github/renovate.json) =="
if [ -f .github/renovate.json ]; then
cat -n .github/renovate.json | head -20
else
echo ".github/renovate.json not found"
fi
echo
echo "== Dependabot configuration (.github/dependabot.yml) =="
if [ -f .github/dependabot.yml ]; then
cat -n .github/dependabot.yml
echo
echo "== Searching for gomod in dependabot.yml =="
rg -n 'gomod' .github/dependabot.yml || echo "No 'gomod' found in dependabot.yml"
else
echo ".github/dependabot.yml not found"
fiRepository: openshift/managed-cluster-validating-webhooks
Length of output: 1721
Remove gomod from Renovate's enabledManagers or from Dependabot.
The gomod manager is now enabled in Renovate (line 8), but .github/dependabot.yml still has an active gomod package-ecosystem entry (line 16). Both systems will attempt to manage the same dependencies, creating duplicate PR streams. Choose one tool for gomod updates and disable it in the other.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/renovate.json around lines 6 - 8, You have duplicate dependency
management for Go modules: the `gomod` manager is enabled in Renovate's
enabledManagers configuration, and `.github/dependabot.yml` also has an active
`gomod` package-ecosystem entry. This causes both tools to create separate PRs
for the same dependencies. Choose one tool to manage Go module dependencies and
disable it in the other. Either remove `gomod` from the enabledManagers array in
the Renovate configuration, or remove the gomod package-ecosystem entry from the
Dependabot configuration—pick one tool to be the single source of truth for
gomod updates.
Add enabledManagers tekton/gomod in renovate.json; boilerplate-update when no equivalent upstream PR is already open.
MitaliBhalla
force-pushed
the
rosa-745-mintmaker-gomod
branch
from
e2896c8 to
f03a560
Compare
|
Refreshed branch: minimal ROSA-745 diff (renovate enabledManagers; boilerplate-update only if no parallel boilerplate PR). |
|
@MitaliBhalla: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Closing ROSA-745 fleet PR — superseded by corrected rollout plan. Problem: these PRs bundled redundant repo-root enabledManagers (already inherited via extends openshift/boilerplate #748), unnecessary boilerplate churn, and PKO/fixture noise. A fresh minimal PR per repo will follow the correct model. Jira: ROSA-745 |
3 participants
Summary
make boilerplate-update(includes boilerplate #748 dependabot template).github/renovate.json—enabledManagers: [tekton, gomod]for MintMaker gomod PRsTest plan
Jira: ROSA-745
Summary by CodeRabbit