Skip to content

Test PR to bump some deps and kick Konflux#584

Closed
joshbranham wants to merge 1 commit into
openshift:masterfrom
joshbranham:wip/bump-some-deps
Closed

Test PR to bump some deps and kick Konflux#584
joshbranham wants to merge 1 commit into
openshift:masterfrom
joshbranham:wip/bump-some-deps

Conversation

@joshbranham

@joshbranham joshbranham commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Updated a few third-party dependencies to newer versions, including OpenShift-related libraries and a Prometheus utility package.

@openshift-ci openshift-ci Bot requested review from diakovnec and tnierman June 29, 2026 14:31
@openshift-ci

openshift-ci Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joshbranham

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2026
@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 284ed247-6ce2-4fec-8293-a5c0826a9596

📥 Commits

Reviewing files that changed from the base of the PR and between 79d1262 and 75bfb44.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod

Walkthrough

Updates go.mod to bump two direct OpenShift dependencies (github.com/openshift/api and github.com/openshift/osde2e-common) to newer timestamped revisions, and bumps the indirect dependency github.com/prometheus/common from v0.66.1 to v0.67.5.

Changes

Dependency Version Bumps

Layer / File(s) Summary
go.mod version bumps
go.mod
Bumps github.com/openshift/api and github.com/openshift/osde2e-common to newer revisions, and bumps indirect github.com/prometheus/common from v0.66.1 to v0.67.5.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change: bumping dependencies, with the Konflux trigger noted as a secondary purpose.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR changes only go.mod dependency versions; no test files or Ginkgo titles were modified, and existing titles are static.
Test Structure And Quality ✅ Passed Only go.mod and go.sum changed; no Ginkgo/test files were modified, so the test-structure review is not applicable.
Microshift Test Compatibility ✅ Passed PR only changes go.mod/go.sum dependency versions; no new Ginkgo e2e tests or MicroShift-sensitive test code were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only bumps deps in go.mod/go.sum; no Ginkgo tests were added or changed, so no new SNO assumptions to review.
Topology-Aware Scheduling Compatibility ✅ Passed PR only bumps dependencies in go.mod; no deployment manifests, controllers, or scheduling logic changed, so topology-aware scheduling constraints aren’t introduced.
Ote Binary Stdout Contract ✅ Passed PR only updates go.mod/go.sum dependency versions; no process-level code or stdout writes were changed.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Diff only changes go.mod and go.sum; no new Ginkgo/e2e tests or network code were added, so this check is not applicable.
No-Weak-Crypto ✅ Passed PR only bumps dependency versions in go.mod/go.sum; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons were added.
Container-Privileges ✅ Passed PR only bumps go.mod deps; the checked pod templates keep runAsNonRoot=true, allowPrivilegeEscalation=false, and capabilities.drop=ALL, with no privileged flags added.
No-Sensitive-Data-In-Logs ✅ Passed Only go.mod/go.sum dependency bumps changed; no new logging statements or sensitive-data-bearing code were added.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

@joshbranham: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant