Add pull_secret_multiple_sync_failures service log template#400
Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:masterfrom Feb 4, 2026
Conversation
This template will be used after changes to the osdctl validate-pull-secret-ext command to aggregate multiple pull secret validation failures into a single service log with a comma-separated list of affected authentication sources. Related: SREP-3365 Created with assistance from Claude 🤖 <claude@anthropic.com> Signed-off-by: Chris Collins <collins.christopher@gmail.com>
clcollins
added a commit
to clcollins/osdctl
that referenced
this pull request
Feb 3, 2026
Aggregates multiple pull secret validation failures into a single service log instead of prompting for each failure individually. This improves the user experience and reduces service log noise. Changes: - Aggregate failures and send one service log at end of validation - Add --skip-service-logs flag for testing/automation - Use new pull_secret_multiple_sync_failures.json template - Add helper functions: buildTemplateParameters, formatFailureDisplay, recordServiceLogFailure, sendAggregatedServiceLogs - Update validation functions to record failures instead of sending immediately - Remove obsolete sendPullSecretServiceLog and sendPullSecretMismatchServiceLog - Add comprehensive unit tests for new functions Related: SREP-3365, SREP-3321 Depends on: openshift/managed-notifications#400 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Chris Collins <collins.christopher@gmail.com>
This template will be used after changes to the osdctl validate-pull-secret-ext command to aggregate multiple pull secret validation failures into a single service log with a comma-separated list of affected authentication sources. Related: SREP-3365 Created with assistance from Claude 🤖 <claude@anthropic.com> Signed-off-by: Chris Collins <collins.christopher@gmail.com>
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clcollins, geowa4 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Contributor
|
@clcollins: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new service log template to support aggregated failure reporting in the
osdctl cluster validate-pull-secret-extcommand.Related JIRA
SREP-3365
What's being added
New template:
osd/pull_secret_multiple_sync_failures.jsonThis template will be used when the
validate-pull-secret-extcommand detects issues in multiple (2+) authentication sources. Instead of sending separate service logs for each failure, the command will aggregate them into a single service log with a comma-separated list of affected auth sources.Template details
${FAILURE_LIST}- comma-separated list of authentication sources with issuesExample usage
When multiple auth sources have issues (e.g.,
cloud.openshift.com, quay.io, registry.redhat.io), the service log will read:Why one template instead of two
The generic wording "Issues were detected" covers all failure scenarios without needing separate templates for email mismatches vs. structural/sync failures.
Follow-up work
After this template is merged, Phase 2 will implement the code changes in
openshift/osdctlto use this template for aggregated failure reporting.Created with assistance from Claude 🤖