SREP-3321: Improve log clarity for delete-olm-operator dry-run mode#240
SREP-3321: Improve log clarity for delete-olm-operator dry-run mode#240clcollins wants to merge 1 commit intoopenshift:mainfrom
Conversation
During incident response, SREs ran the delete-olm-operator job without the FORCE=y parameter and incorrectly assumed the job had completed its work when it was only describing what would be deleted. This led to operational confusion and extended incident duration. Changes: - Add prominent dry-run mode banner at script start - Prefix all dry-run messages with [DRY-RUN] - Change "Will delete" to "Would delete" to clarify hypothetical actions - Add final summary banner for both dry-run and execution modes - Include clear instructions to execute with --params FORCE=y These changes make it immediately obvious whether the script is running in dry-run mode or actually executing deletions, preventing operational mistakes during incident response. Related: https://issues.redhat.com/browse/SREP-3321 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
@clcollins: This pull request references SREP-3321 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: clcollins The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@clcollins: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/hold for testing on-cluster |
openshift-ci
bot
added
the
do-not-merge/hold
2 participants
Summary
Improves log output clarity for the
operators-lifecycle/delete-olm-operatormanaged job to prevent operational confusion during incident response.Problem
During incident response, SREs ran the delete-olm-operator job without the
FORCE=yparameter and incorrectly assumed the job had completed its work when it was only describing what would be deleted. The previous log output used ambiguous language like "Will delete..." which sounded like future action rather than hypothetical action.Changes
[DRY-RUN]for immediate visual distinction--params FORCE=yin both banner messagesBenefits
Test Plan
Related: https://issues.redhat.com/browse/SREP-3321
🤖 Generated with Claude Code