OCPBUGS-79422: fix single interface uplink validation in NNCP wizard by upalatucci · Pull Request #179 · openshift/nmstate-console-plugin

upalatucci · 2026-03-24T19:39:09Z

Summary

Fix the "Next" button being permanently disabled when selecting a NIC in the "A single interface" uplink connection option of the NNCP creation wizard.
The validation expected exactly 1 bridge port, but selecting a NIC sets 2 ports (physical NIC + OVS internal interface ovs-br1). Updated NUM_INTERFACES_FOR_SINGLE_INTERFACE_UPLINK from 1 to 2.
This also fixes a secondary issue where the "Next" button was incorrectly enabled before any NIC was selected.

DEMO

Screen.Recording.2026-03-24.at.20.45.02.mov

Test plan

Create NNCP from form
Move to Uplink connection and select "A single interface"
Select an interface — verify the "Next" button is now enabled
Verify that before selecting any NIC, the "Next" button is disabled

Made with Cursor

openshift-ci-robot · 2026-03-24T19:39:16Z

@upalatucci: This pull request references Jira Issue OCPBUGS-79422, which is invalid:

expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Fix the "Next" button being permanently disabled when selecting a NIC in the "A single interface" uplink connection option of the NNCP creation wizard.

The validation expected exactly 1 bridge port, but selecting a NIC sets 2 ports (physical NIC + OVS internal interface ovs-br1). Updated NUM_INTERFACES_FOR_SINGLE_INTERFACE_UPLINK from 1 to 2.

This also fixes a secondary issue where the "Next" button was incorrectly enabled before any NIC was selected.

Test plan

Create NNCP from form

Move to Uplink connection and select "A single interface"

Select an interface — verify the "Next" button is now enabled

Verify that before selecting any NIC, the "Next" button is disabled

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-03-24T19:39:25Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c807354e-8320-47c4-b75d-214040ca654c

📥 Commits

Reviewing files that changed from the base of the PR and between 8ac1c53 and 5120be5.

📒 Files selected for processing (1)

src/utils/components/PolicyForm/PolicyWizard/utils/constants.ts

🚧 Files skipped from review as they are similar to previous changes (1)

src/utils/components/PolicyForm/PolicyWizard/utils/constants.ts

Walkthrough

A single numeric constant in PolicyWizard utilities was changed: NUM_INTERFACES_FOR_SINGLE_INTERFACE_UPLINK updated from 1 to 2, altering the threshold used to identify a single-interface uplink configuration.

Changes

Cohort / File(s)	Summary
PolicyWizard Constants `src/utils/components/PolicyForm/PolicyWizard/utils/constants.ts`	Changed exported constant `NUM_INTERFACES_FOR_SINGLE_INTERFACE_UPLINK` from `1` to `2`.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci · 2026-03-24T19:41:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pcbailey · 2026-03-25T00:46:50Z

/retest

When selecting a NIC in the "A single interface" uplink option, the bridge ports are set to two entries (physical NIC + OVS internal interface), but validation expected exactly one port, causing the Next button to stay disabled. Made-with: Cursor

pcbailey · 2026-03-31T11:59:48Z

/lgtm

upalatucci · 2026-03-31T12:31:17Z

/jira refresh

openshift-ci-robot · 2026-03-31T12:31:24Z

@upalatucci: This pull request references Jira Issue OCPBUGS-79422, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

upalatucci · 2026-03-31T12:31:38Z

/cherry-pick release-4.21

openshift-cherrypick-robot · 2026-03-31T12:31:41Z

@upalatucci: once the present PR merges, I will cherry-pick it on top of release-4.21 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

upalatucci · 2026-03-31T14:38:03Z

/retest

openshift-ci · 2026-03-31T16:05:47Z

@upalatucci: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2026-03-31T16:10:41Z

@upalatucci: Jira Issue OCPBUGS-79422: All pull requests linked via external trackers have merged:

openshift/nmstate-console-plugin#179

Jira Issue OCPBUGS-79422 has been moved to the MODIFIED state.

Details

In response to this:

Summary

Fix the "Next" button being permanently disabled when selecting a NIC in the "A single interface" uplink connection option of the NNCP creation wizard.

The validation expected exactly 1 bridge port, but selecting a NIC sets 2 ports (physical NIC + OVS internal interface ovs-br1). Updated NUM_INTERFACES_FOR_SINGLE_INTERFACE_UPLINK from 1 to 2.

This also fixes a secondary issue where the "Next" button was incorrectly enabled before any NIC was selected.

DEMO

Screen.Recording.2026-03-24.at.20.45.02.mov

Test plan

Create NNCP from form

Move to Uplink connection and select "A single interface"

Select an interface — verify the "Next" button is now enabled

Verify that before selecting any NIC, the "Next" button is disabled

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-cherrypick-robot · 2026-03-31T16:11:31Z

@upalatucci: new pull request created: #183

Details

In response to this:

/cherry-pick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 24, 2026

openshift-ci bot requested review from metalice and pcbailey March 24, 2026 19:41

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2026

upalatucci force-pushed the OCPBUGS-79422-fix-single-interface-uplink-validation branch from 8ac1c53 to 5120be5 Compare March 26, 2026 15:42

openshift-ci bot assigned pcbailey Mar 31, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2026

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 31, 2026

openshift-merge-bot bot merged commit bdfb3ce into openshift:main Mar 31, 2026
4 checks passed

openshift-cherrypick-robot mentioned this pull request Mar 31, 2026

[release-4.21] OCPBUGS-81501: fix single interface uplink validation in NNCP wizard #183

Open

Conversation

upalatucci commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

openshift-ci-robot commented Mar 24, 2026

Summary

Test plan

Uh oh!

coderabbitai bot commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

openshift-ci bot commented Mar 24, 2026

Uh oh!

pcbailey commented Mar 25, 2026

Uh oh!

pcbailey commented Mar 31, 2026

Uh oh!

upalatucci commented Mar 31, 2026

Uh oh!

openshift-ci-robot commented Mar 31, 2026

Uh oh!

upalatucci commented Mar 31, 2026

Uh oh!

openshift-cherrypick-robot commented Mar 31, 2026

Uh oh!

upalatucci commented Mar 31, 2026

Uh oh!

openshift-ci bot commented Mar 31, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 31, 2026

Summary

Test plan

Uh oh!

openshift-cherrypick-robot commented Mar 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

upalatucci commented Mar 24, 2026 •

edited

Loading

coderabbitai bot commented Mar 24, 2026 •

edited

Loading