Skip to content

DO-NOT-MERGE: Add unit tests that prove bug OCPBUGS-63228#212

Draft
liouk wants to merge 1 commit into
openshift:masterfrom
liouk:prove-fix-OCPBUGS-63228
Draft

DO-NOT-MERGE: Add unit tests that prove bug OCPBUGS-63228#212
liouk wants to merge 1 commit into
openshift:masterfrom
liouk:prove-fix-OCPBUGS-63228

Conversation

@liouk

@liouk liouk commented Feb 25, 2026

Copy link
Copy Markdown
Member

This PR contains proof unit tests for the fix in #211. The tests will also be added to that PR and must pass there.

Note that we are expecting TestRemoveUserFromGroup_DoesNotMutateCachedObject/remove_first_user_(case_0) to pass anyway because Users[1:] is a sub-slice that doesn't mutate the array

/hold

@liouk liouk marked this pull request as draft February 25, 2026 15:19
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 25, 2026
@liouk

liouk commented Feb 25, 2026

Copy link
Copy Markdown
Member Author

/test unit

@openshift-ci openshift-ci Bot requested review from deads2k and ibihim February 25, 2026 15:20
@openshift-ci

openshift-ci Bot commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liouk
Once this PR has been reviewed and has the lgtm label, please assign ibihim for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

@liouk: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit 2ee8e88 link true /test unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant