chore: bump Go 1.25 and ART images for 4.22#216
Conversation
The ART image bump for 4.22 updates .ci-operator.yaml and images/Dockerfile.rhel to use Go 1.25 builder images, but go.mod was still at 1.24.0. The verify-golang-versions check requires all three to agree.
… with ART for 4.22 Cherry-picked from ART PR openshift#207.
WalkthroughUpdates Go toolchain from 1.24.0 to 1.25.0 and OpenShift base images from 4.21 to 4.22 across build configuration, dependency manifest, and Docker build files. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment Tip CodeRabbit can enforce grammar and style rules using `languagetool`.Configure the |
openshift-ci
Bot
added
the
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Line 3: The go.mod contains an invalid Go version directive ("go 1.25.0");
update the module's Go version directive in go.mod to a real released patch (for
example "go 1.25.8") so it matches an official Go release and won't break
builds, then run a quick verification (e.g., go version or go env GOMOD) to
confirm the toolchain accepts the change.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 2b4895c2-b1ef-4152-8e1c-8b3643ffdff0
📒 Files selected for processing (3)
.ci-operator.yamlgo.modimages/Dockerfile.rhel
| module github.com/openshift/oauth-server | ||
|
|
||
| go 1.24.0 | ||
| go 1.25.0 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify Go 1.25.0 is a valid released version
curl -s https://go.dev/dl/?mode=json | jq -r '.[].version' | grep -E '^go1\.25' | head -5Repository: openshift/oauth-server
Length of output: 74
Go 1.25.0 is not a valid released version and will cause build failures.
The verification shows that only go1.25.8 exists in the official Go releases. Verify which 1.25.x version should be used (e.g., go1.25.8) and update go.mod accordingly to match the actual available release.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@go.mod` at line 3, The go.mod contains an invalid Go version directive ("go
1.25.0"); update the module's Go version directive in go.mod to a real released
patch (for example "go 1.25.8") so it matches an official Go release and won't
break builds, then run a quick verification (e.g., go version or go env GOMOD)
to confirm the toolchain accepts the change.
|
@ibihim: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ibihim, liouk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
Summary
go.modfrom Go 1.24.0 to Go 1.25.0 to match the ART image update.ci-operator.yamlandimages/Dockerfile.rhelupdated to 4.22 builder/base images with Go 1.25)The ART PR #207 was failing
verify-golang-versionsbecause it bumped the CI and Dockerfile images to Go 1.25 butgo.modwas still at 1.24. This PR fixes the mismatch and includes the ART changes, superseding #207.Test plan
go build ./...compiles cleanlymake test-unitpassesmake verifypasses (includingverify-golang-versions)