fix typo: 'occured' -> 'occurred' in osinserver error responses#230
fix typo: 'occured' -> 'occurred' in osinserver error responses#230SAY-5 wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughTypo correction in error messages across three OAuth server handlers. The spelling of "occurred" is fixed in ChangesError Message Typo Fix
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @SAY-5. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: SAY-5 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pkg/osinserver/osinserver.go`:
- Line 95: Search for remaining misspellings of "occured" (e.g., the call
http.Error(w, "An error occured", ...) in the OAuth external handler) and
correct the message to use "occurred"; update any other occurrences of the same
typo across the codebase so all error strings read "occurred" consistently
(ensure you change the literal text passed to http.Error and any similar
user-facing messages).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 6e4f4b79-167e-4714-9afc-3e7ef05c0af7
📒 Files selected for processing (1)
pkg/osinserver/osinserver.go
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
Corrects the spelling of "occurred" in the
http.Errormessages emitted bypkg/osinserver/osinserver.gowhen JSON output fails.Summary by CodeRabbit