Skip to content

fix typo: 'occured' -> 'occurred' in osinserver error responses#230

Open
SAY-5 wants to merge 2 commits into
openshift:masterfrom
SAY-5:say5-typo-occured-osinserver
Open

fix typo: 'occured' -> 'occurred' in osinserver error responses#230
SAY-5 wants to merge 2 commits into
openshift:masterfrom
SAY-5:say5-typo-occured-osinserver

Conversation

@SAY-5

@SAY-5 SAY-5 commented May 11, 2026

Copy link
Copy Markdown

Corrects the spelling of "occurred" in the http.Error messages emitted by pkg/osinserver/osinserver.go when JSON output fails.

Summary by CodeRabbit

  • Bug Fixes
    • Corrected typo in internal server error messages across authentication endpoints — "occurred" now displays properly.
    • Ensures consistent, polished wording for 500-level error responses during token, authorization, and info operations.

@coderabbitai

coderabbitai Bot commented May 11, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: edf6011d-a471-4441-8e59-d36e9e99ab12

📥 Commits

Reviewing files that changed from the base of the PR and between 38987d1 and 43ff58d.

📒 Files selected for processing (1)
  • pkg/oauth/external/handler.go
✅ Files skipped from review due to trivial changes (1)
  • pkg/oauth/external/handler.go

Walkthrough

Typo correction in error messages across three OAuth server handlers. The spelling of "occurred" is fixed in http.Error responses when JSON output serialization fails in the OSIN server module.

Changes

Error Message Typo Fix

Layer / File(s) Summary
Error Messages (OSIN handlers)
pkg/osinserver/osinserver.go
Spelling of "occurred" corrected in http.Error responses for osin.OutputJSON failures across handleAuthorize, handleToken, and handleInfo handlers.
Error Message (OAuth external handler)
pkg/oauth/external/handler.go
Spelling of "occurred" corrected in the http.Error response used by Handler.handleError.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: correcting a typo from 'occured' to 'occurred' in error response messages across the osinserver handlers.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only modifies non-test files with typo fixes. No Ginkgo test names are added or modified; check not applicable.
Test Structure And Quality ✅ Passed PR only fixes typos in error messages (no test code modified). Repository uses standard Go testing, not Ginkgo framework, so the check is not applicable.
Microshift Test Compatibility ✅ Passed PR only fixes typos in error messages (no new Ginkgo e2e tests added). The check is not applicable since it targets only new test declarations.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR only corrects typos in error message strings ("occured" → "occurred") in two non-test files and adds no new Ginkgo e2e tests, making the SNO compatibility check not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR only fixes typos in HTTP error messages in handler code, not deployment/operator/controller code with scheduling constraints.
Ote Binary Stdout Contract ✅ Passed PR only corrects spelling in error messages used by http.Error() in HTTP handler methods, not process-level code; no stdout writes introduced.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only fixes typos in error messages; no new Ginkgo e2e tests are added, so IPv6/disconnected network check does not apply.
No-Weak-Crypto ✅ Passed PR contains only typo fixes in error message strings ("occured" → "occurred"). No cryptographic code, algorithms, imports, or security-sensitive comparisons are modified or introduced.
Container-Privileges ✅ Passed PR only modifies Go source files with typo corrections; no container/K8s manifests modified or added, so container-privileges check is not applicable.
No-Sensitive-Data-In-Logs ✅ Passed Changes are spelling corrections only ("occured" → "occurred" in generic HTTP error messages). No sensitive data logging is added, modified, or removed.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from ibihim and liouk May 11, 2026 00:08
@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 11, 2026
@openshift-ci

openshift-ci Bot commented May 11, 2026

Copy link
Copy Markdown
Contributor

Hi @SAY-5. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci

openshift-ci Bot commented May 11, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SAY-5
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@pkg/osinserver/osinserver.go`:
- Line 95: Search for remaining misspellings of "occured" (e.g., the call
http.Error(w, "An error occured", ...) in the OAuth external handler) and
correct the message to use "occurred"; update any other occurrences of the same
typo across the codebase so all error strings read "occurred" consistently
(ensure you change the literal text passed to http.Error and any similar
user-facing messages).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6e4f4b79-167e-4714-9afc-3e7ef05c0af7

📥 Commits

Reviewing files that changed from the base of the PR and between 3aa95c0 and 38987d1.

📒 Files selected for processing (1)
  • pkg/osinserver/osinserver.go

Comment thread pkg/osinserver/osinserver.go
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant