OCPBUGS-58458: update examples with gatewayClassName#106085
OCPBUGS-58458: update examples with gatewayClassName#106085jldohmann wants to merge 1 commit intoopenshift:mainfrom
Conversation
|
@jldohmann: This pull request references Jira Issue OCPBUGS-58458, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@lihongan could you PTAL at this docs PR for QE ack? it updates the example GWAPI resources to include the |
|
🤖 Thu Feb 05 21:39:27 - Prow CI generated the docs preview: |
|
@jldohmann: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| gatewayClassName: openshift-default | ||
| listeners: | ||
| - name: https | ||
| protocol: HTTPS |
There was a problem hiding this comment.
I just realized that if using "HTTPS" then tls.certificateRefs is required, and also need to explain how to create secret for it.
To make it simple and just focus the namespace selector here, please update to
- name: http
protocol: HTTP
port: 80
Please note we need insert port: 80 here. Thanks
| gatewayClassName: openshift-default | ||
| listeners: | ||
| - name: http | ||
| protocol: HTTP |
There was a problem hiding this comment.
Please update next line port: 8080 to port: 80. Thanks
Version(s): 4.19+
Issue: https://issues.redhat.com/browse/OCPBUGS-58458
Link to docs preview:
QE review:
Additional information: