Skip to content

OCPBUGS-58458: update examples with gatewayClassName#106085

Open
jldohmann wants to merge 1 commit intoopenshift:mainfrom
jldohmann:OCPBUGS-58458
Open

OCPBUGS-58458: update examples with gatewayClassName#106085
jldohmann wants to merge 1 commit intoopenshift:mainfrom
jldohmann:OCPBUGS-58458

Conversation

@jldohmann
Copy link
Contributor

Version(s): 4.19+

Issue: https://issues.redhat.com/browse/OCPBUGS-58458

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@jldohmann jldohmann added this to the Continuous Release milestone Feb 5, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 5, 2026
@openshift-ci-robot
Copy link

@jldohmann: This pull request references Jira Issue OCPBUGS-58458, which is invalid:

  • expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Version(s): 4.19+

Issue: https://issues.redhat.com/browse/OCPBUGS-58458

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jldohmann
Copy link
Contributor Author

@lihongan could you PTAL at this docs PR for QE ack? it updates the example GWAPI resources to include the gatewayClassName. thank you 🙇

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 5, 2026
@ocpdocs-previewbot
Copy link

@openshift-ci
Copy link

openshift-ci bot commented Feb 5, 2026

@jldohmann: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

gatewayClassName: openshift-default
listeners:
- name: https
protocol: HTTPS
Copy link

@lihongan lihongan Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that if using "HTTPS" then tls.certificateRefs is required, and also need to explain how to create secret for it.
To make it simple and just focus the namespace selector here, please update to

  - name: http
    protocol: HTTP
    port: 80

Please note we need insert port: 80 here. Thanks

gatewayClassName: openshift-default
listeners:
- name: http
protocol: HTTP
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update next line port: 8080 to port: 80. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.19 branch/enterprise-4.20 branch/enterprise-4.21 branch/enterprise-4.22 jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants