OLS-2613:Update OLS docs for MCP header and definition changes#106086
OLS-2613:Update OLS docs for MCP header and definition changes#106086rh-tokeefe wants to merge 1 commit intoopenshift:lightspeed-docs-mainfrom
Conversation
|
@rh-tokeefe: This pull request references OLS-2613 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
size/M
|
@rh-tokeefe: This pull request references OLS-2613 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
🤖 Mon Feb 09 19:34:15 - Prow CI generated the docs preview: |
|
/retest |
|
/lgtm |
| <4> Specifies the time that the MCP server has to respond to a query. If the client does not receive a query within the time specified, the MCP server times out. In this example, the timeout is 30 seconds. | ||
| <5> Define MCP headers as an array of structured objects containing the key-value pairs required for server authentication and context. | ||
| <6> Specifies the key that the server uses to authorize the credentials. | ||
| <7> Specifies the Kubernetes Secret you are referencing. |
There was a problem hiding this comment.
| <7> Specifies the Kubernetes Secret you are referencing. | |
| <7> Specifies the Kubernetes Object you are referencing. |
|
New changes are detected. LGTM label has been removed. |
|
@rh-tokeefe: This pull request references OLS-2613 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
gwynnemonahan
left a comment
gwynnemonahan
left a comment
There was a problem hiding this comment.
Render issue, otherwise LGTM.
Note: Tim stated that callouts are being addressed separately, so this still follows the numbered method instead of the definition list or bullet list.
| <6> Specifies the key that the server uses to authorize the credentials. | ||
| <7> Specifies the Kubernetes object you are referencing. | ||
| <8> Specifies the name of the Kubernetes Secret object. | ||
| <9> Requires 'kubernetes' to be explicitly stated to fetch values from cluster resources. |
There was a problem hiding this comment.
'kubernetes' doesn't render properly in the preview. It also looks like its in italics here.
|
@rh-tokeefe: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
LGTM. |
6 participants
Affects:
lightspeed-main
lightspeed-docs-1.0
PR must be CP'd back to the lightspeed-docs-1.0 branch.
Issue:
https://issues.redhat.com/browse/OLS-2613
Link to docs preview:
QE review:
Additional information: